You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "errose28 (via GitHub)" <gi...@apache.org> on 2023/12/08 03:52:09 UTC
[PR] HDDS-9578. Create skeleton for Ozone homepage [ozone-site]
errose28 opened a new pull request, #52:
URL: https://github.com/apache/ozone-site/pull/52
- Create a basic Ozone homepage that can be completed later.
- Add header and footer with links and pages
- Add custom color theming
- Add a clean Ozone SVG logo
- Other SVG logos are retrieved from the following sources:
- Github header inline svg: [YuniKorn website](https://github.com/apache/yunikorn-site/blob/78b58dfda17756891e0a1bbfff63f0df32e12c71/src/css/custom.css#L45) (Apache)
- Jira footer: [Ignite website](https://github.com/apache/ignite-website/blob/e7e725a8cf4438c7b8ef277e0483f8688c5b4fd9/img/icon-jira.svg?plain=1) (Apache)
- Github footer: [Ignite website](https://github.com/apache/ignite/blame/d053cb880484ac61f96c297d8c73f4184818ff6a/docs/assets/images/github-gray.svg) (Apache)
- All others: [Bootstrap Icons](https://icons.getbootstrap.com/) (MIT)
## Known Issues (Probably to be fixed in follow up tasks)
- When the website is in dark mode, sometimes there is a white background on the svg logos in the footer, even though the footer color does not change.
- svg icons in the footer flicker when changing pages.
- Algolia search cannot be activated until the site is published to ozone.apache.org. In the mean time the search bar does not work and may throw errors in developer mode.
- svg icons are kind of hacked in right now.
- The github icon in the header is inlined to accept styling (taken from an example in the YuniKorn website).
- The foreground color of the icons in footer was changed to match the text in the svg file itself. I could not get them to accept css styling using the `fill=currentColor` property in the svg file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9578. Create skeleton for Ozone homepage [ozone-site]
Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 commented on PR #52:
URL: https://github.com/apache/ozone-site/pull/52#issuecomment-1854538354
I had been having an issue where the local deployment of the site would become unresponsive and Chrome's memory would spike to around 5gb until I closed the tab. After some experimenting it seems this is some bug in docusaurus or chrome that is related to how I have inlined the html for the footer icons in the docusaurus config. This can probably be worked around by swizzling parts of the footer. We will need this bug fixed before merging this change since those contributing to the docs will hit it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9578. Create skeleton for Ozone homepage [ozone-site]
Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 commented on PR #52:
URL: https://github.com/apache/ozone-site/pull/52#issuecomment-1850561272
cc @daveteng0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9578. Create skeleton for Ozone homepage [ozone-site]
Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 commented on PR #52:
URL: https://github.com/apache/ozone-site/pull/52#issuecomment-1858289404
Thanks for the review @swagle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9578. Create skeleton for Ozone homepage [ozone-site]
Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 merged PR #52:
URL: https://github.com/apache/ozone-site/pull/52
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org