You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by okram <gi...@git.apache.org> on 2017/03/21 14:14:20 UTC
[GitHub] tinkerpop pull request #578: TINKERPOP-1625: Improvements to has() related s...
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/578
TINKERPOP-1625: Improvements to has() related steps
https://issues.apache.org/jira/browse/TINKERPOP-1625
Added tests for `hasKey()` and `hasValue()`. Also tweaked up `HasTest` which had dangling traversers not being tested. Updated docs with `hasKey()` and `hasValue()` examples. Note that in the documentation we do not use Java var args conventions, but instead try and keep it general to all languages. Thus, the "technique" of `hasKey(String,String...)` is simply `hasKey(keys...)`.
VOTE +1.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1625
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/578.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #578
----
commit 2138c8e196d7b08a10510e7dffe744087e2c8e05
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2017-03-20T17:55:08Z
Changed benchmark for addVertex() to use the object array params
This is a the more likely way folks would add a vertex with the Graph API so it's a better comparison. Ultimately, the speed of the benchmark didn't change that much so that's good. CTR
commit a2fccf11e04101bf946fbfff50eb9d4ea2465853
Author: Marko A. Rodriguez <ok...@gmail.com>
Date: 2017-03-21T14:08:25Z
added hasKey() and hasValue() tests to HasTest. Removed un-tested methods in HasTest that someone wrote, but never added respective test cases for. Added more has()-examples to the 'Has Step' section of the documentation.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #578: TINKERPOP-1625: Improvements to has() related s...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/578
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #578: TINKERPOP-1625: Improvements to has() related steps
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/578
`docker/build.sh -t -n -i` succeeded.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #578: TINKERPOP-1625: Improvements to has() related steps
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/578
sorry - i still gotta fix that on tp32. i didn't get to it yesterday.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #578: TINKERPOP-1625: Improvements to has() related steps
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/578
Is it time to rebase this branch? Integration test just failed for me (`shouldDetachVertexWhenRemoved` in `Neo4j Gremlin`).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #578: TINKERPOP-1625: Improvements to has() related steps
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/578
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #578: TINKERPOP-1625: Improvements to has() related steps
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/578
```
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:09 h
[INFO] Finished at: 2017-03-21T12:28:49-06:00
[INFO] Final Memory: 145M/1708M
[INFO] ------------------------------------------------------------------------
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #578: TINKERPOP-1625: Improvements to has() related steps
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/578
I encountered some test failures with neo4j, but I think its unrelated to this change. Not sure why it doesn't fail on tp32 (as it should). Going to try to get the fix in on tp32 today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #578: TINKERPOP-1625: Improvements to has() related steps
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/578
Ok - pushed the fix to tp32/master. @okram you can rebase this branch at this point on tp32 and get the fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---