[GitHub] [calcite] hsyuan commented on a change in pull request #1576: [CALCITE-3285] EnumerableMergeJoin should support non-equi join condi…

[GitBox <gi...@apache.org>]

hsyuan commented on a change in pull request #1576: [CALCITE-3285] EnumerableMergeJoin should support non-equi join condi…
URL: https://github.com/apache/calcite/pull/1576#discussion_r347041067
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableConvention.java
 ##########
 @@ -34,6 +34,13 @@
    * "typical" calling convention. */
   public static final double COST_MULTIPLIER = 1.0d;
 
+  /**
+   * User can switch this config to allow conversion by
+   * {@link org.apache.calcite.plan.volcano.AbstractConverter}, which is relied
+   * upon when converting collations/distributions of input to fit the parent node.
+   */
+  public static boolean useAbstractConvertersForConversion = false;
 
 Review comment:
   This should be used for test purpose only, right? If yes, can you mark it with `For private use only, may be removed without notice`?
   The value should not be dynamically changed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services