You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by sebb <se...@gmail.com> on 2012/05/18 03:11:06 UTC
Re: svn commit: r1339894 - /jmeter/trunk/xdocs/usermanual/component_reference.xml
On 17 May 2012 23:28, <pm...@apache.org> wrote:
> Author: pmouawad
> Date: Thu May 17 22:28:08 2012
> New Revision: 1339894
>
> URL: http://svn.apache.org/viewvc?rev=1339894&view=rev
> Log:
> Commenting Reports section as it's empty
-1
This causes test case failures.
> Modified:
> jmeter/trunk/xdocs/usermanual/component_reference.xml
>
> Modified: jmeter/trunk/xdocs/usermanual/component_reference.xml
> URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/usermanual/component_reference.xml?rev=1339894&r1=1339893&r2=1339894&view=diff
> ==============================================================================
> --- jmeter/trunk/xdocs/usermanual/component_reference.xml (original)
> +++ jmeter/trunk/xdocs/usermanual/component_reference.xml Thu May 17 22:28:08 2012
> @@ -5450,7 +5450,7 @@ The Test Fragment is used in conjunction
> <a href="#">^</a>
>
> </section>
> -
> +<!--
> <section name="§-num;.10 Reports" anchor="Reports">
> <description>
> <br></br>
> @@ -5483,6 +5483,6 @@ The Test Fragment is used in conjunction
> <a href="#">^</a>
>
> </section>
> -
> + -->
> </body>
> </document>
>
>
Re: svn commit: r1339894 - /jmeter/trunk/xdocs/usermanual/component_reference.xml
Posted by sebb <se...@gmail.com>.
On 18 May 2012 13:47, Philippe Mouawad <ph...@gmail.com> wrote:
> Hello sebb,
> You are right, it seems I didn't run tests after commeting out this section
> . I didn't know that tests checked documentation for all GUI components
> which is great.
> I fixed it by adding a new condition on Report package and ReportGUI as it
> seems to me these components are incomplete.
The ideal fix would be to add the missing documentation ...
> By the way what's the exact status of the report package, is it supposed to
> be implemented ? or is it already implemented ?
AFAIK it does work, though I've never used it other than
experimenting, and that was for a much earlier JMeter version.
> Reading sometimes its code
> , there seems to be some copy/paste from JMeter core but I don't know the
> history of it.
Yes, it uses the same code to configure the reports.
Just run the appropriate jmeter-report shell script to get started.
> Thanks
> Regards
> Philippe
>
> On Fri, May 18, 2012 at 12:02 PM, sebb <se...@gmail.com> wrote:
>
>> On 18 May 2012 10:40, Philippe Mouawad <ph...@gmail.com> wrote:
>> > Hello Sebb,
>> > Did you fix it or do you want me to do it ?
>>
>> Please revert the change.
>> Perhaps add a comment to say why the entries are needed.
>>
>> > Which test fails ?
>>
>> The test that fails is
>>
>> runGUITitle(org.apache.jmeter.junit.JMeterTest)
>>
>> > I didn't notice it running locally but it's certainly
>>
>> What test did you run?
>>
>> The command
>> ant test
>> fails for me.
>>
>> > due to site not yet Being live with these modifications.
>>
>> Unlikely, as the test uses component_reference.xml directly.
>>
>> > Regards
>> > Philippe
>> >
>> > On Friday, May 18, 2012, sebb wrote:
>> >
>> >> On 17 May 2012 23:28, <pmouawad@apache.org <javascript:;>> wrote:
>> >> > Author: pmouawad
>> >> > Date: Thu May 17 22:28:08 2012
>> >> > New Revision: 1339894
>> >> >
>> >> > URL: http://svn.apache.org/viewvc?rev=1339894&view=rev
>> >> > Log:
>> >> > Commenting Reports section as it's empty
>> >>
>> >> -1
>> >>
>> >> This causes test case failures.
>> >>
>> >> > Modified:
>> >> > jmeter/trunk/xdocs/usermanual/component_reference.xml
>> >> >
>> >> > Modified: jmeter/trunk/xdocs/usermanual/component_reference.xml
>> >> > URL:
>> >>
>> http://svn.apache.org/viewvc/jmeter/trunk/xdocs/usermanual/component_reference.xml?rev=1339894&r1=1339893&r2=1339894&view=diff
>> >> >
>> >>
>> ==============================================================================
>> >> > --- jmeter/trunk/xdocs/usermanual/component_reference.xml (original)
>> >> > +++ jmeter/trunk/xdocs/usermanual/component_reference.xml Thu May 17
>> >> 22:28:08 2012
>> >> > @@ -5450,7 +5450,7 @@ The Test Fragment is used in conjunction
>> >> > <a href="#">^</a>
>> >> >
>> >> > </section>
>> >> > -
>> >> > +<!--
>> >> > <section name="§-num;.10 Reports" anchor="Reports">
>> >> > <description>
>> >> > <br></br>
>> >> > @@ -5483,6 +5483,6 @@ The Test Fragment is used in conjunction
>> >> > <a href="#">^</a>
>> >> >
>> >> > </section>
>> >> > -
>> >> > + -->
>> >> > </body>
>> >> > </document>
>> >> >
>> >> >
>> >>
>> >
>> >
>> > --
>> > Cordialement.
>> > Philippe Mouawad.
>>
>
>
>
> --
> Cordialement.
> Philippe Mouawad.
Re: svn commit: r1339894 - /jmeter/trunk/xdocs/usermanual/component_reference.xml
Posted by Philippe Mouawad <ph...@gmail.com>.
Hello sebb,
You are right, it seems I didn't run tests after commeting out this section
. I didn't know that tests checked documentation for all GUI components
which is great.
I fixed it by adding a new condition on Report package and ReportGUI as it
seems to me these components are incomplete.
By the way what's the exact status of the report package, is it supposed to
be implemented ? or is it already implemented ? Reading sometimes its code
, there seems to be some copy/paste from JMeter core but I don't know the
history of it.
Thanks
Regards
Philippe
On Fri, May 18, 2012 at 12:02 PM, sebb <se...@gmail.com> wrote:
> On 18 May 2012 10:40, Philippe Mouawad <ph...@gmail.com> wrote:
> > Hello Sebb,
> > Did you fix it or do you want me to do it ?
>
> Please revert the change.
> Perhaps add a comment to say why the entries are needed.
>
> > Which test fails ?
>
> The test that fails is
>
> runGUITitle(org.apache.jmeter.junit.JMeterTest)
>
> > I didn't notice it running locally but it's certainly
>
> What test did you run?
>
> The command
> ant test
> fails for me.
>
> > due to site not yet Being live with these modifications.
>
> Unlikely, as the test uses component_reference.xml directly.
>
> > Regards
> > Philippe
> >
> > On Friday, May 18, 2012, sebb wrote:
> >
> >> On 17 May 2012 23:28, <pmouawad@apache.org <javascript:;>> wrote:
> >> > Author: pmouawad
> >> > Date: Thu May 17 22:28:08 2012
> >> > New Revision: 1339894
> >> >
> >> > URL: http://svn.apache.org/viewvc?rev=1339894&view=rev
> >> > Log:
> >> > Commenting Reports section as it's empty
> >>
> >> -1
> >>
> >> This causes test case failures.
> >>
> >> > Modified:
> >> > jmeter/trunk/xdocs/usermanual/component_reference.xml
> >> >
> >> > Modified: jmeter/trunk/xdocs/usermanual/component_reference.xml
> >> > URL:
> >>
> http://svn.apache.org/viewvc/jmeter/trunk/xdocs/usermanual/component_reference.xml?rev=1339894&r1=1339893&r2=1339894&view=diff
> >> >
> >>
> ==============================================================================
> >> > --- jmeter/trunk/xdocs/usermanual/component_reference.xml (original)
> >> > +++ jmeter/trunk/xdocs/usermanual/component_reference.xml Thu May 17
> >> 22:28:08 2012
> >> > @@ -5450,7 +5450,7 @@ The Test Fragment is used in conjunction
> >> > <a href="#">^</a>
> >> >
> >> > </section>
> >> > -
> >> > +<!--
> >> > <section name="§-num;.10 Reports" anchor="Reports">
> >> > <description>
> >> > <br></br>
> >> > @@ -5483,6 +5483,6 @@ The Test Fragment is used in conjunction
> >> > <a href="#">^</a>
> >> >
> >> > </section>
> >> > -
> >> > + -->
> >> > </body>
> >> > </document>
> >> >
> >> >
> >>
> >
> >
> > --
> > Cordialement.
> > Philippe Mouawad.
>
--
Cordialement.
Philippe Mouawad.
Re: svn commit: r1339894 - /jmeter/trunk/xdocs/usermanual/component_reference.xml
Posted by sebb <se...@gmail.com>.
On 18 May 2012 10:40, Philippe Mouawad <ph...@gmail.com> wrote:
> Hello Sebb,
> Did you fix it or do you want me to do it ?
Please revert the change.
Perhaps add a comment to say why the entries are needed.
> Which test fails ?
The test that fails is
runGUITitle(org.apache.jmeter.junit.JMeterTest)
> I didn't notice it running locally but it's certainly
What test did you run?
The command
ant test
fails for me.
> due to site not yet Being live with these modifications.
Unlikely, as the test uses component_reference.xml directly.
> Regards
> Philippe
>
> On Friday, May 18, 2012, sebb wrote:
>
>> On 17 May 2012 23:28, <pmouawad@apache.org <javascript:;>> wrote:
>> > Author: pmouawad
>> > Date: Thu May 17 22:28:08 2012
>> > New Revision: 1339894
>> >
>> > URL: http://svn.apache.org/viewvc?rev=1339894&view=rev
>> > Log:
>> > Commenting Reports section as it's empty
>>
>> -1
>>
>> This causes test case failures.
>>
>> > Modified:
>> > jmeter/trunk/xdocs/usermanual/component_reference.xml
>> >
>> > Modified: jmeter/trunk/xdocs/usermanual/component_reference.xml
>> > URL:
>> http://svn.apache.org/viewvc/jmeter/trunk/xdocs/usermanual/component_reference.xml?rev=1339894&r1=1339893&r2=1339894&view=diff
>> >
>> ==============================================================================
>> > --- jmeter/trunk/xdocs/usermanual/component_reference.xml (original)
>> > +++ jmeter/trunk/xdocs/usermanual/component_reference.xml Thu May 17
>> 22:28:08 2012
>> > @@ -5450,7 +5450,7 @@ The Test Fragment is used in conjunction
>> > <a href="#">^</a>
>> >
>> > </section>
>> > -
>> > +<!--
>> > <section name="§-num;.10 Reports" anchor="Reports">
>> > <description>
>> > <br></br>
>> > @@ -5483,6 +5483,6 @@ The Test Fragment is used in conjunction
>> > <a href="#">^</a>
>> >
>> > </section>
>> > -
>> > + -->
>> > </body>
>> > </document>
>> >
>> >
>>
>
>
> --
> Cordialement.
> Philippe Mouawad.
Re: svn commit: r1339894 - /jmeter/trunk/xdocs/usermanual/component_reference.xml
Posted by Philippe Mouawad <ph...@gmail.com>.
Hello Sebb,
Did you fix it or do you want me to do it ?
Which test fails ? I didn't notice it running locally but it's certainly
due to site not yet Being live with these modifications.
Regards
Philippe
On Friday, May 18, 2012, sebb wrote:
> On 17 May 2012 23:28, <pmouawad@apache.org <javascript:;>> wrote:
> > Author: pmouawad
> > Date: Thu May 17 22:28:08 2012
> > New Revision: 1339894
> >
> > URL: http://svn.apache.org/viewvc?rev=1339894&view=rev
> > Log:
> > Commenting Reports section as it's empty
>
> -1
>
> This causes test case failures.
>
> > Modified:
> > jmeter/trunk/xdocs/usermanual/component_reference.xml
> >
> > Modified: jmeter/trunk/xdocs/usermanual/component_reference.xml
> > URL:
> http://svn.apache.org/viewvc/jmeter/trunk/xdocs/usermanual/component_reference.xml?rev=1339894&r1=1339893&r2=1339894&view=diff
> >
> ==============================================================================
> > --- jmeter/trunk/xdocs/usermanual/component_reference.xml (original)
> > +++ jmeter/trunk/xdocs/usermanual/component_reference.xml Thu May 17
> 22:28:08 2012
> > @@ -5450,7 +5450,7 @@ The Test Fragment is used in conjunction
> > <a href="#">^</a>
> >
> > </section>
> > -
> > +<!--
> > <section name="§-num;.10 Reports" anchor="Reports">
> > <description>
> > <br></br>
> > @@ -5483,6 +5483,6 @@ The Test Fragment is used in conjunction
> > <a href="#">^</a>
> >
> > </section>
> > -
> > + -->
> > </body>
> > </document>
> >
> >
>
--
Cordialement.
Philippe Mouawad.