[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #2935: [NETBEANS-5656] Various smaller fixes in the database New Connection wizard

[GitBox <gi...@apache.org>]

matthiasblaesing commented on a change in pull request #2935:
URL: https://github.com/apache/netbeans/pull/2935#discussion_r626045114



##########
File path: ide/db/src/org/netbeans/modules/db/explorer/Bundle.properties
##########
@@ -21,7 +21,10 @@ SchemaIsNotSet=Default schema
 
 EXC_InsufficientConnInfo=insufficient information to create a connection
 # {0} is database URL, {1} is the database driver name, {2} is additional info 
-EXC_CannotEstablishConnection=Cannot establish a connection to {0} using {1} ({2})
+# The "New Connection Wizard" only has space for the first part of the message, so put the message
+# from the driver (parameter {2}), which usually explains the error, first.
+#EXC_CannotEstablishConnection=Cannot establish a connection to {0} using {1} ({2})

Review comment:
       I would remove this - the explanation is sound, but line 26 can be removed.

##########
File path: ide/db/src/org/netbeans/modules/db/util/Bundle.properties
##########
@@ -37,6 +37,7 @@ DRIVERNAME_OracleOCI=Oracle OCI
 DRIVERNAME_JTDS=jTDS
 DRIVERNAME_DB2JCC=IBM DB2 Universal Driver
 DRIVERNAME_MSSQL2005=Microsoft SQL Server 2005
+DRIVERNAME_MSSQL=Microsoft SQL Server

Review comment:
       If "DRIVERNAME_MSSQL2005" is unused (a grep through the codebase should show that), please remove it. Else I think it would be better to only modify the value and not the key.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists