You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2016/06/28 08:04:32 UTC
[GitHub] zeppelin pull request #1100: [ZEPPELIN-1054] Improve "Credentials" UI
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/1100
[ZEPPELIN-1054] Improve "Credentials" UI
### What is this PR for?
Currently, users can add new their credential info for data source authentication in Zeppelin "Credentials" menu. Even though it was saved successfully, they can't see the whole list of credentials in Zeppelin UI.
This PR enables to `get` all credential list, `edit` and `remove` via UI.
*NOTE : Since this patch was implemented based on #1030 API, should be tested after #1030 merged.*
### What type of PR is it?
Improvement & Documentation
### Todos
* [x] - rename `interpreter_authorization.md` -> `datasource_authorization.md`
* [x] - remove `Interpreter Authorization` section (since we don't have this feature yet : [ZEPPELIN-945](https://issues.apache.org/jira/browse/ZEPPELIN-945))
* [ ] - rebase after #1030 & #1064 merged
### What is the Jira issue?
[ZEPPELIN-1054](https://issues.apache.org/jira/browse/ZEPPELIN-1054)
### How should this be tested?
1. Apply this patch and build `zeppelin-web` as described in [here](https://github.com/apache/zeppelin/tree/master/zeppelin-web#configured-environment).
2. Go to `Credentials` menu.
3. Add new credentials -> you can see the credential info in the credential list table.
4. You can edit & delete them. -> Compare with `conf/credentials.json`
### Screenshots (if appropriate)
- Before
<img width="952" alt="screen shot 2016-06-28 at 12 37 10 am" src="https://cloud.githubusercontent.com/assets/10060731/16407604/69b0c4d8-3cc9-11e6-8284-9abe2969cdc1.png">
- After
If there is no credential
<img width="957" alt="screen shot 2016-06-28 at 12 19 46 am" src="https://cloud.githubusercontent.com/assets/10060731/16407620/7838995e-3cc9-11e6-90ba-1bd0173a1b49.png">
- `datasource_authorization.md`
<img width="836" alt="1" src="https://cloud.githubusercontent.com/assets/10060731/16407680/d176ddf0-3cc9-11e6-9070-178400ad7c86.png">
<img width="829" alt="2" src="https://cloud.githubusercontent.com/assets/10060731/16407681/d4168d8a-3cc9-11e6-9319-018ae440cef8.png">
<img width="842" alt="3" src="https://cloud.githubusercontent.com/assets/10060731/16407682/d5f36a10-3cc9-11e6-8b9a-13b09960cda6.png">
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin ZEPPELIN-1054
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1100.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1100
----
commit 3681e96d84e8fe9094c3149685e61b51e914eab0
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2016-06-27T17:35:02Z
Enable credential info to get list, edit and remove via UI
commit 50ea0ac2549b70bdd96bd292bc3be63a0f5b7060
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2016-06-27T17:35:25Z
Update angular-xeditable version
commit 00cc690b1a2fc17c35b7c76d703c8f9f500450b5
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2016-06-27T17:34:11Z
Add datasource_authorization.md to index & navi menu
commit 071f18f82b71719b2e88aafbe77734d17ec02701
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2016-06-28T07:14:33Z
Add datasource_authorization.md docs
commit f7c6a7d1832f3d7516e3388b2fdbe5e6a81bcc9c
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2016-06-28T07:56:33Z
Fix indentation
commit 32e5809a9d7c80cfcd83a6b2501f8dc50dbbf537
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2016-06-28T08:03:55Z
Delete interpreter_authorization.md
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1100: [ZEPPELIN-1054] Improve "Credentials" UI
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1100
Ready for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1100: [ZEPPELIN-1054] Improve "Credentials" UI
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1100
I'm keep getting `GET http://localhost:8080/api/credential 405 (Method Not Allowed)`, when i visit credential menu. @AhyoungRyu Could you check?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1100: [ZEPPELIN-1054] Improve "Credentials" UI
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1100
In the case of login from credential page, its a separate issue, you shouldn't be able to do that.
I created an issue: https://issues.apache.org/jira/browse/ZEPPELIN-1123 and will take care of it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1100: [ZEPPELIN-1054] Improve "Credentials" UI
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1100
CI failure is not related and is fixed under [ZEPPELIN-1063](https://issues.apache.org/jira/browse/ZEPPELIN-1063)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1100: [ZEPPELIN-1054] Improve "Credentials" UI
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1100
Looks good to me, \cc @corneadoug @felizbear for review of the frontend part
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1100: [ZEPPELIN-1054] Improve "Credentials" UI
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1100
@AhyoungRyu Can you rebase your branch please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1100: [ZEPPELIN-1054] Improve "Credentials" UI
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1100
@Leemoonsoo Since this PR needs #1030's extended API, I rebased from master. Maybe now it works properly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1100: [ZEPPELIN-1054] Improve "Credentials" UI
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1100
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1100: [ZEPPELIN-1054] Improve "Credentials" UI
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1100
@corneadoug Really appreciate for your effort! I addressed your last comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1100: [ZEPPELIN-1054] Improve "Credentials" UI
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1100
@corneadoug yeah I did :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1100: [ZEPPELIN-1054] Improve "Credentials" UI
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1100
@corneadoug All CI builds failed. Seems they are related with [ZEPPELIN-1016](https://issues.apache.org/jira/browse/ZEPPELIN-1016) or [ZEPPELIN-1126](https://issues.apache.org/jira/browse/ZEPPELIN-1126).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1100: [ZEPPELIN-1054] Improve "Credentials" UI
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1100
Tested and overall working well. Found two (minor) problems
When i login from Credential page, list not refreshed after logged in
"Edit" -> "Save" -> "Cancel" -> "Cancel" does not update actual credential in the backend. However, it displays modified value in frontend, until page is refreshed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1100: [ZEPPELIN-1054] Improve "Credentials" UI
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1100
Latest commit (41413df) can also be reverted
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1100: [ZEPPELIN-1054] Improve "Credentials" UI
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1100
Really great feature! Thanks for making this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1100: [ZEPPELIN-1054] Improve "Credentials" UI
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1100
@felizbear This PR can be tested after #1030 merged as I described in the above.
* **Register** : you don't need to register if you don't want. It needs [shiro authentication setting](https://zeppelin.apache.org/docs/0.6.0-SNAPSHOT/security/shiroauthentication.html). But still you can add your credential info as `anonymous`, even if you didn't activate shiro. It's a default setting.
* **Docs link** : Regarding docs link, you can't see currently since this docs was newly added by this PR. If you want to see this docs, you have to build the website in your local as described in [here](https://github.com/apache/zeppelin/tree/master/docs#build-documentation). It's little bit tiresome, so I added screenshot images.
And appreciate for your feedbacks. I'll take a look at it :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1100: [ZEPPELIN-1054] Improve "Credentials" UI
Posted by felizbear <gi...@git.apache.org>.
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/1100
Not sure how to test in the browser because I have to log in, but I have no clue how to register. And don't really understand why I have to do it to access settings.
Link to documentation on the main page is broken.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1100: [ZEPPELIN-1054] Improve "Credentials" UI
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1100
CI is green, merging if there is no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---