[GitHub] [hbase] zhuyaogai commented on a diff in pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

["zhuyaogai (via GitHub)" <gi...@apache.org>]

zhuyaogai commented on code in PR #5228:
URL: https://github.com/apache/hbase/pull/5228#discussion_r1320499288


##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java:
##########
@@ -753,6 +787,40 @@ public void updateRpc(MethodDescriptor method, Message param, CallStats stats, T
     updateRpcGeneric(methodName.toString(), stats);
   }
 
+  /** Report table rpc context to metrics system. */
+  private void updateTableMetric(String methodName, TableName tableName,
+    HBaseProtos.RegionSpecifier regionSpecifier, Message param, CallStats stats, Throwable e) {
+    if (tableMetricsEnabled) {
+      if (methodName != null) {
+        String table;
+        if (tableName == null || StringUtils.isEmpty(tableName.getNameAsString())) {
+          // Fallback to get table name from region specifier.

Review Comment:
   @bbeaudreault hi, I have already modified the code according to your requirements. Could you continue the code review for me if you are available? Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org