You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gabor Apati-Nagy <ga...@citrix.com> on 2014/09/16 21:36:07 UTC

Review Request 25706: CLOUDSTACK-7561: UI: After creating a new account, the "Add Account" dialog remains open

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25706/
-----------------------------------------------------------

Review request for cloudstack, Brian Federle and Jessica Wang.


Bugs: CLOUDSTACK-7561
    https://issues.apache.org/jira/browse/CLOUDSTACK-7561


Repository: cloudstack-git


Description
-------

Deleted code that was raising exception when it tried to call non-existing function.


Diffs
-----

  ui/scripts/accountsWizard.js f0221932706c5c68a343104c9745c1b7a5177a72 

Diff: https://reviews.apache.org/r/25706/diff/


Testing
-------

After adding an account using the UI there were no exceptions raised and the dialog closes properly.


Thanks,

Gabor Apati-Nagy


Re: Review Request 25706: CLOUDSTACK-7561: UI: After creating a new account, the "Add Account" dialog remains open

Posted by Brian Federle <br...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25706/#review53960
-----------------------------------------------------------

Ship it!


Ship It!

- Brian Federle


On Sept. 16, 2014, 7:36 p.m., Gabor Apati-Nagy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25706/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2014, 7:36 p.m.)
> 
> 
> Review request for cloudstack, Brian Federle and Jessica Wang.
> 
> 
> Bugs: CLOUDSTACK-7561
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7561
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Deleted code that was raising exception when it tried to call non-existing function.
> 
> 
> Diffs
> -----
> 
>   ui/scripts/accountsWizard.js f0221932706c5c68a343104c9745c1b7a5177a72 
> 
> Diff: https://reviews.apache.org/r/25706/diff/
> 
> 
> Testing
> -------
> 
> After adding an account using the UI there were no exceptions raised and the dialog closes properly.
> 
> 
> Thanks,
> 
> Gabor Apati-Nagy
> 
>