You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Mark Hindess <ma...@googlemail.com> on 2006/07/06 17:12:12 UTC
Re: svn commit: r419557 - in /incubator/harmony/enhanced/drlvm/trunk/vm: interpreter/src/interpreter.cpp vmcore/src/init/vm.cpp vmcore/src/jit/jit_runtime_support.cpp vmcore/src/verifier/Verifier.cpp
On 6 July 2006 at 10:36, Geir Magnusson Jr <ge...@pobox.com> wrote:
> Ivan Volosyuk wrote:
>
> > It is good to see that we finally have java1.5 support in
> > DRLVM. One small question, why my authorship was discarded from
> > interpreter.cpp? :)
>
> Nothing personal - just a habit... I'm just nipping off author tags
> as I go along ...
Didn't this used to be ASF policy? I thought I recall hearing (at
ApacheCon) that this had changed and that authorship tags were now
allowed.
> ... as this code belongs to all of us.
Agreed.
> Maybe it's time to revisit this - does anyone really want them?
Personally, no. I don't like them. If you put one name in then
everyone who edits it should be entitled to add their name and that just
gets out of hand.
As you say the code belongs to all of us.
Regards,
Mark.
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: svn commit: r419557 - in /incubator/harmony/enhanced/drlvm/trunk/vm:
interpreter/src/interpreter.cpp vmcore/src/init/vm.cpp vmcore/src/jit/jit_runtime_support.cpp
vmcore/src/verifier/Verifier.cpp
Posted by Geir Magnusson Jr <ge...@pobox.com>.
Mark Hindess wrote:
> On 6 July 2006 at 10:36, Geir Magnusson Jr <ge...@pobox.com> wrote:
>
>> Ivan Volosyuk wrote:
>>
>>> It is good to see that we finally have java1.5 support in
>>> DRLVM. One small question, why my authorship was discarded from
>>> interpreter.cpp? :)
>> Nothing personal - just a habit... I'm just nipping off author tags
>> as I go along ...
>
> Didn't this used to be ASF policy? I thought I recall hearing (at
> ApacheCon) that this had changed and that authorship tags were now
> allowed.
The always were allowed. The board once recommended against them and
sometimes recommendations get mis-interpreted as laws.
>
>> ... as this code belongs to all of us.
>
> Agreed.
>
>> Maybe it's time to revisit this - does anyone really want them?
>
> Personally, no. I don't like them. If you put one name in then
> everyone who edits it should be entitled to add their name and that just
> gets out of hand.
Exactly. What we'll do is make an authors file in root so that everyone
gets credit for contribution. We don't ever want to leave anyone out -
credit where credit due...
>
> As you say the code belongs to all of us.
Or
"All your code are belong to us"
>
> Regards,
> Mark.
>
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: svn commit: r419557 - in /incubator/harmony/enhanced/drlvm/trunk/vm: interpreter/src/interpreter.cpp vmcore/src/init/vm.cpp vmcore/src/jit/jit_runtime_support.cpp vmcore/src/verifier/Verifier.cpp
Posted by Ivan Volosyuk <iv...@gmail.com>.
Anyway, I want to make a few changes in interpreter code. There is a
fix for a few floating-point to integer conversions' bytecodes which
make incorrect clumping. An improvement for diagnostic messages in
AbstractMethodError and IllegalAccessError. Is it the right time to do
this kind of changes?
On 7/6/06, Ivan Volosyuk <iv...@gmail.com> wrote:
> On 7/6/06, Mark Hindess <ma...@googlemail.com> wrote:
..........
> Btw, I have a few bug fixes. Shell I post it to harmony-dev for
> discussion or just submit its to JIRA?
> --
> Ivan
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: author tags
Posted by Weldon Washburn <we...@gmail.com>.
+1 in favor of dumping author tags.
On 7/6/06, Geir Magnusson Jr <ge...@pobox.com> wrote:
> please categorize subject lines...
>
> Tim Ellison wrote:
> > Ivan Volosyuk wrote:
> >> A little bit upset, that I'm no longer mentioned as author of the
> >> interpreter.cpp, it was quite a bit of work; not perfect I know.
> >
> > Sorry that you feel that way. Your feelings illustrates to me why it is
> > easier and arguably fairer to never have author tags. The intent is not
> > to upset people by omitting some names and not others, or getting into
> > debates about whether a JavaDoc spelling correction warrants authorship,
> > etc.
> >
> > I understand that others have opposing opinions, and I don't feel
> > strongly about it.
> >
> > Regards,
> > Tim
> >
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
--
Weldon Washburn
Intel Middleware Products Division
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: author tags
Posted by Geir Magnusson Jr <ge...@pobox.com>.
please categorize subject lines...
Tim Ellison wrote:
> Ivan Volosyuk wrote:
>> A little bit upset, that I'm no longer mentioned as author of the
>> interpreter.cpp, it was quite a bit of work; not perfect I know.
>
> Sorry that you feel that way. Your feelings illustrates to me why it is
> easier and arguably fairer to never have author tags. The intent is not
> to upset people by omitting some names and not others, or getting into
> debates about whether a JavaDoc spelling correction warrants authorship,
> etc.
>
> I understand that others have opposing opinions, and I don't feel
> strongly about it.
>
> Regards,
> Tim
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
author tags (was: Re: svn commit: r419557 - in /incubator/harmony/enhanced/drlvm/trunk/vm:
interpreter/src/interpreter.cpp vmcore/src/init/vm.cpp vmcore/src/jit/jit_runtime_support.cpp
vmcore/src/verifier/Verifier.cpp)
Posted by Tim Ellison <t....@gmail.com>.
Ivan Volosyuk wrote:
> A little bit upset, that I'm no longer mentioned as author of the
> interpreter.cpp, it was quite a bit of work; not perfect I know.
Sorry that you feel that way. Your feelings illustrates to me why it is
easier and arguably fairer to never have author tags. The intent is not
to upset people by omitting some names and not others, or getting into
debates about whether a JavaDoc spelling correction warrants authorship,
etc.
I understand that others have opposing opinions, and I don't feel
strongly about it.
Regards,
Tim
--
Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: svn commit: r419557 - in /incubator/harmony/enhanced/drlvm/trunk/vm: interpreter/src/interpreter.cpp vmcore/src/init/vm.cpp vmcore/src/jit/jit_runtime_support.cpp vmcore/src/verifier/Verifier.cpp
Posted by Ivan Volosyuk <iv...@gmail.com>.
On 7/6/06, Mark Hindess <ma...@googlemail.com> wrote:
>
> On 6 July 2006 at 10:36, Geir Magnusson Jr <ge...@pobox.com> wrote:
>
> > Ivan Volosyuk wrote:
> >
> > > It is good to see that we finally have java1.5 support in
> > > DRLVM. One small question, why my authorship was discarded from
> > > interpreter.cpp? :)
> >
> > Nothing personal - just a habit... I'm just nipping off author tags
> > as I go along ...
>
> Didn't this used to be ASF policy? I thought I recall hearing (at
> ApacheCon) that this had changed and that authorship tags were now
> allowed.
>
> > ... as this code belongs to all of us.
>
> Agreed.
>
> > Maybe it's time to revisit this - does anyone really want them?
>
> Personally, no. I don't like them. If you put one name in then
> everyone who edits it should be entitled to add their name and that just
> gets out of hand.
There authors tags was quite useful in DRLVM development to find
person responsible for certain component or source file. If it was
difficult to fix a bug or implement some feature related to some
subcomponent I usually contacted the author of a file to do the job or
to help me get through.
May be it doesn't makes sense in the open community like harmony.
A little bit upset, that I'm no longer mentioned as author of the
interpreter.cpp, it was quite a bit of work; not perfect I know.
Btw, I have a few bug fixes. Shell I post it to harmony-dev for
discussion or just submit its to JIRA?
--
Ivan
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org