You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/17 10:28:32 UTC
[GitHub] [flink] zentol opened a new pull request #10886:
[FLINK-15623][checkstyle] Exclude target directory
zentol opened a new pull request #10886: [FLINK-15623][checkstyle] Exclude target directory
URL: https://github.com/apache/flink/pull/10886
Excludes the entire `target` directory from checkstyle.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10886:
[FLINK-15623][checkstyle] Exclude target directory
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10886: [FLINK-15623][checkstyle] Exclude target directory
URL: https://github.com/apache/flink/pull/10886#issuecomment-575570132
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 3e5838bf83f80d1ab34dc91fa55f2ee812847a6e (Fri Jan 17 10:32:47 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol merged pull request #10886:
[FLINK-15623][checkstyle] Exclude target directory
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #10886: [FLINK-15623][checkstyle] Exclude target directory
URL: https://github.com/apache/flink/pull/10886
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #10886:
[FLINK-15623][checkstyle] Exclude target directory
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #10886: [FLINK-15623][checkstyle] Exclude target directory
URL: https://github.com/apache/flink/pull/10886#discussion_r372517329
##########
File path: tools/maven/suppressions.xml
##########
@@ -32,13 +32,6 @@ under the License.
<suppress files="org[\\/]apache[\\/]beam[\\/]vendor[\\/]grpc[\\/]v1p21p0[\\/]io[\\/]netty[\\/]buffer.*.java" checks="[a-zA-Z0-9]*"/>
<suppress files="org[\\/]apache[\\/]beam[\\/]runners[\\/]fnexecution[\\/]environment.*.java" checks="[a-zA-Z0-9]*"/>
- <!-- Python streaming API follows python naming conventions -->
- <suppress
- files="org[\\/]apache[\\/]flink[\\/]streaming[\\/]python[\\/]api[\\/].*.java"
- checks="MethodNameCheck|ParameterName"/>
- <suppress
- files="org[\\/]apache[\\/]flink[\\/]streaming[\\/]python[\\/]connectors[\\/].*.java"
- checks="MethodNameCheck|ParameterName"/>
Review comment:
those are for the python streaming api we removed a long time ago.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10886:
[FLINK-15623][checkstyle] Exclude target directory
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10886: [FLINK-15623][checkstyle] Exclude target directory
URL: https://github.com/apache/flink/pull/10886#issuecomment-575583409
<!--
Meta data
Hash:3e5838bf83f80d1ab34dc91fa55f2ee812847a6e Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:3e5838bf83f80d1ab34dc91fa55f2ee812847a6e
-->
## CI report:
* 3e5838bf83f80d1ab34dc91fa55f2ee812847a6e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10886:
[FLINK-15623][checkstyle] Exclude target directory
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10886: [FLINK-15623][checkstyle] Exclude target directory
URL: https://github.com/apache/flink/pull/10886#issuecomment-575583409
<!--
Meta data
Hash:3e5838bf83f80d1ab34dc91fa55f2ee812847a6e Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144917303 TriggerType:PUSH TriggerID:3e5838bf83f80d1ab34dc91fa55f2ee812847a6e
Hash:3e5838bf83f80d1ab34dc91fa55f2ee812847a6e Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4435 TriggerType:PUSH TriggerID:3e5838bf83f80d1ab34dc91fa55f2ee812847a6e
-->
## CI report:
* 3e5838bf83f80d1ab34dc91fa55f2ee812847a6e Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144917303) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4435)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10886:
[FLINK-15623][checkstyle] Exclude target directory
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10886: [FLINK-15623][checkstyle] Exclude target directory
URL: https://github.com/apache/flink/pull/10886#discussion_r373076627
##########
File path: tools/maven/suppressions.xml
##########
@@ -32,13 +32,6 @@ under the License.
<suppress files="org[\\/]apache[\\/]beam[\\/]vendor[\\/]grpc[\\/]v1p21p0[\\/]io[\\/]netty[\\/]buffer.*.java" checks="[a-zA-Z0-9]*"/>
<suppress files="org[\\/]apache[\\/]beam[\\/]runners[\\/]fnexecution[\\/]environment.*.java" checks="[a-zA-Z0-9]*"/>
- <!-- Python streaming API follows python naming conventions -->
- <suppress
- files="org[\\/]apache[\\/]flink[\\/]streaming[\\/]python[\\/]api[\\/].*.java"
- checks="MethodNameCheck|ParameterName"/>
- <suppress
- files="org[\\/]apache[\\/]flink[\\/]streaming[\\/]python[\\/]connectors[\\/].*.java"
- checks="MethodNameCheck|ParameterName"/>
Review comment:
Thanks for the clarification.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10886:
[FLINK-15623][checkstyle] Exclude target directory
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10886: [FLINK-15623][checkstyle] Exclude target directory
URL: https://github.com/apache/flink/pull/10886#discussion_r372513419
##########
File path: tools/maven/suppressions.xml
##########
@@ -32,13 +32,6 @@ under the License.
<suppress files="org[\\/]apache[\\/]beam[\\/]vendor[\\/]grpc[\\/]v1p21p0[\\/]io[\\/]netty[\\/]buffer.*.java" checks="[a-zA-Z0-9]*"/>
<suppress files="org[\\/]apache[\\/]beam[\\/]runners[\\/]fnexecution[\\/]environment.*.java" checks="[a-zA-Z0-9]*"/>
- <!-- Python streaming API follows python naming conventions -->
- <suppress
- files="org[\\/]apache[\\/]flink[\\/]streaming[\\/]python[\\/]api[\\/].*.java"
- checks="MethodNameCheck|ParameterName"/>
- <suppress
- files="org[\\/]apache[\\/]flink[\\/]streaming[\\/]python[\\/]connectors[\\/].*.java"
- checks="MethodNameCheck|ParameterName"/>
Review comment:
Is it because these files are only in the `target` directory?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10886:
[FLINK-15623][checkstyle] Exclude target directory
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10886: [FLINK-15623][checkstyle] Exclude target directory
URL: https://github.com/apache/flink/pull/10886#discussion_r372513221
##########
File path: tools/maven/suppressions.xml
##########
@@ -32,13 +32,6 @@ under the License.
<suppress files="org[\\/]apache[\\/]beam[\\/]vendor[\\/]grpc[\\/]v1p21p0[\\/]io[\\/]netty[\\/]buffer.*.java" checks="[a-zA-Z0-9]*"/>
<suppress files="org[\\/]apache[\\/]beam[\\/]runners[\\/]fnexecution[\\/]environment.*.java" checks="[a-zA-Z0-9]*"/>
- <!-- Python streaming API follows python naming conventions -->
- <suppress
- files="org[\\/]apache[\\/]flink[\\/]streaming[\\/]python[\\/]api[\\/].*.java"
- checks="MethodNameCheck|ParameterName"/>
- <suppress
- files="org[\\/]apache[\\/]flink[\\/]streaming[\\/]python[\\/]connectors[\\/].*.java"
- checks="MethodNameCheck|ParameterName"/>
Review comment:
Why can we remove these suppressions? According to the comment, the Java Python files follow python naming conventions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10886:
[FLINK-15623][checkstyle] Exclude target directory
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10886: [FLINK-15623][checkstyle] Exclude target directory
URL: https://github.com/apache/flink/pull/10886#issuecomment-575583409
<!--
Meta data
Hash:3e5838bf83f80d1ab34dc91fa55f2ee812847a6e Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144917303 TriggerType:PUSH TriggerID:3e5838bf83f80d1ab34dc91fa55f2ee812847a6e
Hash:3e5838bf83f80d1ab34dc91fa55f2ee812847a6e Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4435 TriggerType:PUSH TriggerID:3e5838bf83f80d1ab34dc91fa55f2ee812847a6e
-->
## CI report:
* 3e5838bf83f80d1ab34dc91fa55f2ee812847a6e Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144917303) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4435)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #10886:
[FLINK-15623][checkstyle] Exclude target directory
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #10886: [FLINK-15623][checkstyle] Exclude target directory
URL: https://github.com/apache/flink/pull/10886#discussion_r372517329
##########
File path: tools/maven/suppressions.xml
##########
@@ -32,13 +32,6 @@ under the License.
<suppress files="org[\\/]apache[\\/]beam[\\/]vendor[\\/]grpc[\\/]v1p21p0[\\/]io[\\/]netty[\\/]buffer.*.java" checks="[a-zA-Z0-9]*"/>
<suppress files="org[\\/]apache[\\/]beam[\\/]runners[\\/]fnexecution[\\/]environment.*.java" checks="[a-zA-Z0-9]*"/>
- <!-- Python streaming API follows python naming conventions -->
- <suppress
- files="org[\\/]apache[\\/]flink[\\/]streaming[\\/]python[\\/]api[\\/].*.java"
- checks="MethodNameCheck|ParameterName"/>
- <suppress
- files="org[\\/]apache[\\/]flink[\\/]streaming[\\/]python[\\/]connectors[\\/].*.java"
- checks="MethodNameCheck|ParameterName"/>
Review comment:
those are part of the python streaming api we removed a long time ago.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services