You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Michael Dürig (JIRA)" <ji...@apache.org> on 2016/07/29 12:26:20 UTC

[jira] [Resolved] (OAK-4620) TarReader.getGraphEntrySize() should log IOExceptions

     [ https://issues.apache.org/jira/browse/OAK-4620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Dürig resolved OAK-4620.
--------------------------------
    Resolution: Fixed

Fixed at http://svn.apache.org/viewvc?rev=1754504&view=rev

[~frm] could you double check whether this is the right thing to do. IMO this exception should usually be thrown up to the initial caller. Are we sufficiently sure we can handle this exception here? That is, ignoring it does not lead to unpredictable behaviour elsewhere / at a later time?

> TarReader.getGraphEntrySize() should log IOExceptions
> -----------------------------------------------------
>
>                 Key: OAK-4620
>                 URL: https://issues.apache.org/jira/browse/OAK-4620
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segment-tar
>            Reporter: Michael Dürig
>            Assignee: Michael Dürig
>             Fix For: Segment Tar 0.0.10
>
>
> Currently that method silently ignores any {{IOException}}. It should log a warning instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)