You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by "kusalk (via GitHub)" <gi...@apache.org> on 2023/01/30 12:42:47 UTC
[GitHub] [struts] kusalk opened a new pull request, #656: WW-5278 Collect duplicated code into AbstractActionValidatorManager
kusalk opened a new pull request, #656:
URL: https://github.com/apache/struts/pull/656
WW-5278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] [struts] kusalk commented on a diff in pull request #656: WW-5278 Collect duplicated code into AbstractActionValidatorManager
Posted by "kusalk (via GitHub)" <gi...@apache.org>.
kusalk commented on code in PR #656:
URL: https://github.com/apache/struts/pull/656#discussion_r1090584457
##########
core/src/main/java/com/opensymphony/xwork2/validator/AbstractActionValidatorManager.java:
##########
@@ -276,7 +276,7 @@ protected List<ValidatorConfig> loadFile(String fileName, Class clazz, boolean c
retList = new ArrayList<>(validatorFileParser.parseActionValidatorConfigs(validatorFactory, is, fileName));
}
} catch (IOException e) {
- LOG.error("Caught exception while loading file {}", fileName, e);
Review Comment:
An IOException can only be thrown by `InputStream::close`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [struts] lukaszlenart merged pull request #656: WW-5278 Collect duplicated code into AbstractActionValidatorManager
Posted by "lukaszlenart (via GitHub)" <gi...@apache.org>.
lukaszlenart merged PR #656:
URL: https://github.com/apache/struts/pull/656
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org