You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "unbridled-41 (via GitHub)" <gi...@apache.org> on 2026/10/09 19:20:20 UTC
[PR] fix(settings): reveal the clear action after a signing secret has been saved [rocketmq-dashboard]
unbridled-41 opened a new pull request, #5934:
URL: https://github.com/apache/rocketmq-dashboard/pull/5934
### Which Issue(s) This PR Fixes
Fixes #5933
### Problem / Evidence
`mergeAndSave` reconciles the page state from a settings read taken before the write:
```ts
const base = await loadFreshSettings();
await saveGeneralSettings(buildPayload({ ...base, ...patch }));
setSettings({ ...base, ...statePatch });
```
`dingtalkSigningSecretConfigured` is derived server-side and stripped by `buildPayload`, so it stays false after the save - and it is the sole condition for the clear action:
```
GeneralSettingsTab: reveals the clear action once a signing secret has been saved
TestingLibraryElementError: Unable to find role="button" and name "清除钉钉签名密钥"
```
The operator therefore cannot revoke a mistyped secret without reloading the page, and the fallback ("empty the field, save") reports 保存成功 while `SettingsService` keeps the stored value (blank means "keep the current one") - a wrong secret keeps signing DingTalk notifications. The AI key field in the same page already marks itself configured on a successful save; this form had no equivalent.
### Root cause / Fix
A server-derived marker that the save path never re-derives. Mark the secret configured from the submission itself after a successful save and empty the field so the next save does not resubmit it.
### Priority and scoring
**PRIORITY 52** — impact 18/40 (a secret that cannot be removed or replaced from the UI, and a success message for a save that changed nothing), blast radius 12/20 (every deployment that uses a DingTalk signing secret), reproducibility 18/20 (deterministic, pinned by the new test), maintenance value 4/20.
**FIX_CONFIDENCE 88** — the sibling field on the same page establishes the pattern.
### Tests
`cd web && npx vitest run src/pages/settings/__tests__/GeneralSettingsTab.test.tsx` -> `Tests 9 passed`.
| Test | Before | After |
|---|---|---|
| `reveals the clear action once a signing secret has been saved` | FAIL (no clear button) | PASS |
| `can explicitly clear a configured DingTalk signing secret` | PASS | PASS |
The new case also asserts the field is emptied after the save. `npx eslint` reports no errors; `npx tsc -b` passes.
### Risk
Only the page's own state changes; the payload, the save path and the server behaviour are untouched.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(settings): reveal the clear action after a signing secret has been saved [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #5934: fix(settings): reveal the clear action after a signing secret has been saved
URL: https://github.com/apache/rocketmq-dashboard/pull/5934
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(settings): reveal the clear action after a signing secret has been saved [rocketmq-dashboard]
Posted by "unbridled-41 (via GitHub)" <gi...@apache.org>.
unbridled-41 commented on PR #5934:
URL: https://github.com/apache/rocketmq-dashboard/pull/5934#issuecomment-6087714169
### CI status of this PR
`Backend Tests (Java 21)` — still running at the time of writing; the change-specific commands and their results are in the Tests section of the description.
The four remaining red jobs are red for every branch, including `rocketmq-studio` itself:
- `Backend Build (Java 21)` — the `binary-license-gate` antrun step fails on a list of third-party jars (`spring-ai-*`, `swagger-ui`, `tencentcloud-sdk-*`, `zstd-jni`, ... : "missing complete upstream LICENSE/COPYING; a POM name or link is not a substitute"). This PR touches no build configuration; tracked by #5341.
- `Frontend Build (Node 20)` / `Frontend Docker Build` — the frontend licence manifest check fails the same way on branches that do not touch `web/` at all; tracked by #5346.
- `rmqctl Build (Go)` — `cmd` `TestMessageQueryCompletenessWarningTest` yaml subtests: `got {"items":[{"size":"3",...}]}, want {"size":3,...}`, i.e. the YAML renderer writes numbers as quoted strings where the test expects integer literals. Reproduced locally with `cd rmqctl && go test ./cmd/` from a checkout whose `rmqctl/` tree is byte-identical to `rocketmq-studio`'s, and owned by open PR #5850 ("keep yaml numbers unquoted").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(settings): reveal the clear action after a signing secret has been saved [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5934:
URL: https://github.com/apache/rocketmq-dashboard/pull/5934#issuecomment-6330328989
This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(settings): reveal the clear action after a signing secret has been saved [rocketmq-dashboard]
Posted by "unbridled-41 (via GitHub)" <gi...@apache.org>.
unbridled-41 commented on PR #5934:
URL: https://github.com/apache/rocketmq-dashboard/pull/5934#issuecomment-6091341921
### Verification on the final commit (branch + commit + command results)
Every command from the description re-run on a fresh worktree of this branch (`git worktree add <dir> fork/<branch>`, no local modifications), at commit `1589355369`:
| command | exit | result |
| --- | --- | --- |
| `cd web && npx vitest run src/pages/settings/__tests__/GeneralSettingsTab.test.tsx` | 0 | `Test Files 1 passed (1) · Tests 9 passed (9)` |
CI note: on this repository the `Backend Build` (binary-license-gate), `Frontend Build` / `Frontend Docker Build` (licence manifest) and `rmqctl Build` (YAML renderer quoting) jobs are red for every branch, trunk included; the module-level commands above are unaffected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org