You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by ah...@apache.org on 2021/07/30 14:07:04 UTC

[isis] branch master updated: ISIS-2831: use of href='##' effectively prevents scrolling, is the is no such anchor by the name of '#'

This is an automated email from the ASF dual-hosted git repository.

ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git


The following commit(s) were added to refs/heads/master by this push:
     new 6d271fb  ISIS-2831: use of href='##' effectively prevents scrolling, is the is no such anchor by the name of '#'
6d271fb is described below

commit 6d271fb248c468edb43696124f518244c6b23c08
Author: Andi Huber <ah...@apache.org>
AuthorDate: Fri Jul 30 16:06:51 2021 +0200

    ISIS-2831: use of href='##' effectively prevents scrolling, is the is no
    such anchor by the name of '#'
---
 .../wicket/ui/components/scalars/ScalarPanelTextFieldAbstract.html  | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelTextFieldAbstract.html b/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelTextFieldAbstract.html
index 3e4a3b6..544a65f 100644
--- a/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelTextFieldAbstract.html
+++ b/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelTextFieldAbstract.html
@@ -40,7 +40,8 @@
                         <span class="scalarValueInput">
                             <span class="editing">
 
-                                <a href="#"
+								<!-- ISIS-2831 "##" -->
+                                <a href="##"
                                    name="scalarValueInlinePromptLink"
                                    class="scalarValueInlinePromptLink"
                                    wicket:id="scalarValueInlinePromptLink">
@@ -49,7 +50,8 @@
 
                                 <wicket:container wicket:id="scalarValueContainer"/>
 
-                                <a href="#"
+								<!-- ISIS-2831 "##" -->
+                                <a href="##"
                                    class="edit fa fa-edit"
                                    wicket:id="editProperty"></a>
                             </span>