You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/09/29 20:42:31 UTC
[GitHub] [arrow] kszucs opened a new pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
kszucs opened a new pull request #8304:
URL: https://github.com/apache/arrow/pull/8304
It's a draft for bundling AWS SDK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703562943
@github-actions crossbow submit *-fedora-cpp
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703354088
Revision: 65e2d17a5863ddaa73d6f7b2f51b33214b4d69f1
Submitted crossbow builds: [ursa-labs/crossbow @ actions-595](https://github.com/ursa-labs/crossbow/branches/all?query=actions-595)
|Task|Status|
|----|------|
|conda-linux-gcc-py36-aarch64|[](https://cloud.drone.io/ursa-labs/crossbow)|
|conda-linux-gcc-py36-cpu|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-595-azure-conda-linux-gcc-py36-cpu)|
|conda-linux-gcc-py36-cuda|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-595-azure-conda-linux-gcc-py36-cuda)|
|conda-linux-gcc-py37-aarch64|[](https://cloud.drone.io/ursa-labs/crossbow)|
|conda-linux-gcc-py37-cpu|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-595-azure-conda-linux-gcc-py37-cpu)|
|conda-linux-gcc-py37-cuda|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-595-azure-conda-linux-gcc-py37-cuda)|
|conda-linux-gcc-py38-aarch64|[](https://cloud.drone.io/ursa-labs/crossbow)|
|conda-linux-gcc-py38-cpu|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-595-azure-conda-linux-gcc-py38-cpu)|
|conda-linux-gcc-py38-cuda|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-595-azure-conda-linux-gcc-py38-cuda)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703121523
It appears that the aws-sdk dependencies are installing to a `lib64` directory on these platforms instead of `lib`:
```
[root@add4b8c61e56 r]# ls /build/awssdk_ep-install/lib
cmake libaws-cpp-sdk-core.a libaws-cpp-sdk-sts.a
libaws-cpp-sdk-cognito-identity.a libaws-cpp-sdk-identity-management.a libaws-cpp-sdk-transfer.a
libaws-cpp-sdk-config.a libaws-cpp-sdk-s3.a
[root@add4b8c61e56 r]# ls /build/awssdk_ep-install/
include lib lib64
[root@add4b8c61e56 r]# ls /build/awssdk_ep-install/lib64
aws-c-common aws-checksums libaws-c-common.a libaws-checksums.a
aws-c-event-stream cmake libaws-c-event-stream.a
```
We are already providing CMAKE_INSTALL_DIR and the docs (and source) say this should get passed on to the dependencies. Debugging further.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#discussion_r497047105
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -2630,46 +2628,101 @@ macro(build_awssdk)
endif()
set(AWSSDK_CMAKE_ARGS
- -DCMAKE_BUILD_TYPE=Release
+ -DCMAKE_BUILD_TYPE=release
+ -DMINIMIZE_SIZE=on
+ -DBUILD_ONLY=config\\$<SEMICOLON>s3\\$<SEMICOLON>transfer\\$<SEMICOLON>identity-management\\$<SEMICOLON>sts
-DCMAKE_INSTALL_LIBDIR=lib
- -DBUILD_ONLY=s3;core;config;identity-management;sts
-DENABLE_UNITY_BUILD=on
+ -DBUILD_SHARED_LIBS=off
-DENABLE_TESTING=off
"-DCMAKE_C_FLAGS=${EP_C_FLAGS}"
"-DCMAKE_INSTALL_PREFIX=${AWSSDK_PREFIX}")
- set(
- AWSSDK_CORE_SHARED_LIB
- "${AWSSDK_PREFIX}/lib/${CMAKE_SHARED_LIBRARY_PREFIX}aws-cpp-sdk-core${CMAKE_SHARED_LIBRARY_SUFFIX}"
- )
- set(
- AWSSDK_S3_SHARED_LIB
- "${AWSSDK_PREFIX}/lib/${CMAKE_SHARED_LIBRARY_PREFIX}aws-cpp-sdk-s3${CMAKE_SHARED_LIBRARY_SUFFIX}"
- )
- set(
- AWSSDK_IAM_SHARED_LIB
- "${AWSSDK_PREFIX}/lib/${CMAKE_SHARED_LIBRARY_PREFIX}aws-cpp-sdk-identity-management${CMAKE_SHARED_LIBRARY_SUFFIX}"
- )
- set(
- AWSSDK_STS_SHARED_LIB
- "${AWSSDK_PREFIX}/lib/${CMAKE_SHARED_LIBRARY_PREFIX}aws-cpp-sdk-sts${CMAKE_SHARED_LIBRARY_SUFFIX}"
- )
- set(AWSSDK_SHARED_LIBS "${AWSSDK_CORE_SHARED_LIB}" "${AWSSDK_S3_SHARED_LIB}"
- "${AWSSDK_IAM_SHARED_LIB}" "${AWSSDK_STS_SHARED_LIB}")
+ set(AWSSDK_COMMON_STATIC_LIB "${AWSSDK_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}aws-c-common${CMAKE_STATIC_LIBRARY_SUFFIX}")
Review comment:
Sadly we can't use the FindAWSSDK cmake files to locate the SDK since they are available after the external projects gets built.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703005258
Revision: 5089cb76106ea909aced4e0db32c0d5e9a512bd3
Submitted crossbow builds: [ursa-labs/crossbow @ actions-588](https://github.com/ursa-labs/crossbow/branches/all?query=actions-588)
|Task|Status|
|----|------|
|test-r-rstudio-r-base-3.6-centos6|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-588-azure-test-r-rstudio-r-base-3.6-centos6)|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-588-azure-test-r-rstudio-r-base-3.6-centos8)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703176287
Great!
I'll remove all patches by building aws-c-common, aws-checksums and aws-c-event-stream ourselves.
If we use auto build by aws-swk-cpp, we break our offline build by `cpp/thirdparty/download_dependencies.sh`.
It almost works on local, I'll push it in a few days.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-702928784
Revision: f63aba0e66b74a6777ae8e755c91ba80cd35e1e8
Submitted crossbow builds: [ursa-labs/crossbow @ actions-581](https://github.com/ursa-labs/crossbow/branches/all?query=actions-581)
|Task|Status|
|----|------|
|test-r-rhub-ubuntu-gcc-release|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-581-azure-test-r-rhub-ubuntu-gcc-release)|
|test-r-rocker-r-base-latest|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-581-azure-test-r-rocker-r-base-latest)|
|test-r-rstudio-r-base-3.6-bionic|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-581-azure-test-r-rstudio-r-base-3.6-bionic)|
|test-r-rstudio-r-base-3.6-centos6|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-581-azure-test-r-rstudio-r-base-3.6-centos6)|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-581-azure-test-r-rstudio-r-base-3.6-centos8)|
|test-r-rstudio-r-base-3.6-opensuse15|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-581-azure-test-r-rstudio-r-base-3.6-opensuse15)|
|test-r-rstudio-r-base-3.6-opensuse42|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-581-azure-test-r-rstudio-r-base-3.6-opensuse42)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-702934485
@github-actions crossbow submit test-r-r*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson edited a comment on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson edited a comment on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-701675803
@kou since you're looking at this now, wanted to let you know I'm debugging locally how on the rstudio/r-base:3.6-centos7 image, it [can't find openssl](https://github.com/apache/arrow/pull/8304/checks?check_run_id=1190367574#step:9:122) even though I've yum installed it (debugging and failing, that is, and my next step is the bundled openssl build, the nuclear option I'm afraid). I'm currently skipping that problem though and working on the patch to aws-sdk-cpp so that `git` isn't required.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703903846
> (I think that updating the documentation can be worked as a follow-up task.)
Ok. I'll make a followup JIRA and merge this. Thanks again!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703353884
Revision: 65e2d17a5863ddaa73d6f7b2f51b33214b4d69f1
Submitted crossbow builds: [ursa-labs/crossbow @ actions-595](https://github.com/ursa-labs/crossbow/branches/all?query=actions-595)
|Task|Status|
|----|------|
|conda-osx-clang-py36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-595-azure-conda-osx-clang-py36)|
|conda-osx-clang-py37|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-595-azure-conda-osx-clang-py37)|
|conda-osx-clang-py38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-595-azure-conda-osx-clang-py38)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703000798
@github-actions crossbow submit test-r-rstudio-r-base-3.6-centos8 test-r-rstudio-r-base-3.6-centos6
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-702465566
> * We need to build MinIO on non-amd64 platforms such as arm64
It's not true: https://dl.min.io/server/minio/release/linux-arm64/archive/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-702204251
@corleyma for R on macOS and Windows we're still using binaries for aws-sdk-cpp that are 1.7, so we can't assume 1.8 in the Arrow code just yet. cf. https://github.com/autobrew/homebrew-core/pull/25
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#discussion_r499511967
##########
File path: docker-compose.yml
##########
@@ -248,6 +248,7 @@ services:
cache_from:
- ${REPO}:${ARCH}-ubuntu-${UBUNTU}-cpp
args:
+ arch: ${ARCH}
Review comment:
Good catch!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703390617
Revision: 3e6fc9eac7b1c8b4b1477bdac57e2ae311bf3872
Submitted crossbow builds: [ursa-labs/crossbow @ actions-597](https://github.com/ursa-labs/crossbow/branches/all?query=actions-597)
|Task|Status|
|----|------|
|conda-linux-gcc-py36-aarch64|[](https://cloud.drone.io/ursa-labs/crossbow)|
|conda-linux-gcc-py36-cpu|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-597-azure-conda-linux-gcc-py36-cpu)|
|conda-linux-gcc-py36-cuda|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-597-azure-conda-linux-gcc-py36-cuda)|
|conda-linux-gcc-py37-aarch64|[](https://cloud.drone.io/ursa-labs/crossbow)|
|conda-linux-gcc-py37-cpu|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-597-azure-conda-linux-gcc-py37-cpu)|
|conda-linux-gcc-py37-cuda|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-597-azure-conda-linux-gcc-py37-cuda)|
|conda-linux-gcc-py38-aarch64|[](https://cloud.drone.io/ursa-labs/crossbow)|
|conda-linux-gcc-py38-cpu|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-597-azure-conda-linux-gcc-py38-cpu)|
|conda-linux-gcc-py38-cuda|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-597-azure-conda-linux-gcc-py38-cuda)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703162035
Revision: d3f13d4ca2a63af5d758e900a981c27251a75a90
Submitted crossbow builds: [ursa-labs/crossbow @ actions-591](https://github.com/ursa-labs/crossbow/branches/all?query=actions-591)
|Task|Status|
|----|------|
|test-r-rhub-ubuntu-gcc-release|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-591-azure-test-r-rhub-ubuntu-gcc-release)|
|test-r-rocker-r-base-latest|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-591-azure-test-r-rocker-r-base-latest)|
|test-r-rstudio-r-base-3.6-bionic|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-591-azure-test-r-rstudio-r-base-3.6-bionic)|
|test-r-rstudio-r-base-3.6-centos6|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-591-azure-test-r-rstudio-r-base-3.6-centos6)|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-591-azure-test-r-rstudio-r-base-3.6-centos8)|
|test-r-rstudio-r-base-3.6-opensuse15|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-591-azure-test-r-rstudio-r-base-3.6-opensuse15)|
|test-r-rstudio-r-base-3.6-opensuse42|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-591-azure-test-r-rstudio-r-base-3.6-opensuse42)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703332145
@github-actions crossbow submit test-r-r*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-702989907
Revision: 176d1e6b1a96d8819be4bbbd0815067733c2e54b
Submitted crossbow builds: [ursa-labs/crossbow @ actions-586](https://github.com/ursa-labs/crossbow/branches/all?query=actions-586)
|Task|Status|
|----|------|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-586-azure-test-r-rstudio-r-base-3.6-centos8)|
|test-r-rstudio-r-base-3.6-opensuse15|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-586-azure-test-r-rstudio-r-base-3.6-opensuse15)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-701675803
@kou since you're looking at this now, wanted to let you know I'm debugging locally how on the rstudio/r-base:3.6-centos7 image, it can't find openssl even though I've yum installed it (debugging and failing, that is, and my next step is the bundled openssl build, the nuclear option I'm afraid). I'm currently skipping that problem though and working on the patch to aws-sdk-cpp so that `git` isn't required.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703857874
Revision: 406febf38f380f8e75ecd14af5118c6761baf65d
Submitted crossbow builds: [ursa-labs/crossbow @ actions-603](https://github.com/ursa-labs/crossbow/branches/all?query=actions-603)
|Task|Status|
|----|------|
|test-r-rhub-ubuntu-gcc-release|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-603-azure-test-r-rhub-ubuntu-gcc-release)|
|test-r-rocker-r-base-latest|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-603-azure-test-r-rocker-r-base-latest)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a change in pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#discussion_r497071027
##########
File path: cpp/thirdparty/versions.txt
##########
@@ -24,7 +24,7 @@
# format).
ARROW_ABSL_BUILD_VERSION=2eba343b51e0923cd3fb919a6abd6120590fc059
-ARROW_AWSSDK_BUILD_VERSION=1.7.160
+ARROW_AWSSDK_BUILD_VERSION=1.8.57
Review comment:
We should bump to 1.8 though because of improvements to AWS region detection
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-702424697
Latest R issue(s):
* The R Linux builds do a static Arrow C++ build, which gets pulled into a shared arrow.so library with the R bindings when the R package builds. AFAICT, because the C++ build is static, it insists on the static version of openssl. So IIUC when R makes arrow.so, the openssl symbols will be pulled into the shared library--exactly what folks on https://issues.apache.org/jira/browse/ARROW-10138 were concerned to prevent.
* aws-sdk-cpp doesn't build on gcc 4.8, so we need to catch that in cmake. I'd like to have a way to build like ARROW_S3=IF_POSSIBLE, like build with S3 support if we can but fall back to ARROW_S3=OFF rather than fail the build if some prerequisite is not met (similar to ARROW-8155). If there's no interest in supporting that in cmake itself, I'll find some way to hack that into the R Linux build script.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-702959015
@github-actions crossbow submit test-r-r*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-702441323
@github-actions crossbow submit test-r-rstudio-r-base-3.6-bionic
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703560259
@github-actions crossbow submit *-fedora-cpp *-ubuntu-20.04-cpp* *-debian-10-cpp
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703565732
Revision: 0657942f8b2bb2cfcb6fee8f8c645a481c0816fb
Submitted crossbow builds: [ursa-labs/crossbow @ actions-599](https://github.com/ursa-labs/crossbow/branches/all?query=actions-599)
|Task|Status|
|----|------|
|test-debian-10-cpp|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-599-circle-test-debian-10-cpp)|
|test-fedora-32-cpp|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-599-circle-test-fedora-32-cpp)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-599-github-test-ubuntu-20.04-cpp)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-702449534
@github-actions crossbow submit test-r-rstudio-r-base-3.6-bionic
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-702935169
Revision: 30b888d92c12be28a956ea6042ad892706fdfb69
Submitted crossbow builds: [ursa-labs/crossbow @ actions-582](https://github.com/ursa-labs/crossbow/branches/all?query=actions-582)
|Task|Status|
|----|------|
|test-r-rhub-ubuntu-gcc-release|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-582-azure-test-r-rhub-ubuntu-gcc-release)|
|test-r-rocker-r-base-latest|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-582-azure-test-r-rocker-r-base-latest)|
|test-r-rstudio-r-base-3.6-bionic|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-582-azure-test-r-rstudio-r-base-3.6-bionic)|
|test-r-rstudio-r-base-3.6-centos6|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-582-azure-test-r-rstudio-r-base-3.6-centos6)|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-582-azure-test-r-rstudio-r-base-3.6-centos8)|
|test-r-rstudio-r-base-3.6-opensuse15|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-582-azure-test-r-rstudio-r-base-3.6-opensuse15)|
|test-r-rstudio-r-base-3.6-opensuse42|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-582-azure-test-r-rstudio-r-base-3.6-opensuse42)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703119729
Latest, after fixing openssl shared library finding and adding extra version detection to the R build script:
* test-r-rhub-ubuntu-gcc-release (ubuntu 16.04, gcc 5.4.0): FAIL. C++ build with S3 succeeds but R package link error: `undefined symbol: __cpu_model`
* test-r-rocker-r-base-latest (debian:testing, gcc 9.3.0): SUCCESS with S3
* test-r-rstudio-r-base-3.6-bionic (ubuntu 18.04, gcc 7.5.0): SUCCESS with S3
* test-r-rstudio-r-base-3.6-centos6 (gcc 8.3.1): SUCCESS *without S3* (system openssl is 1.0.1e, but we require 1.0.2)
* test-r-rstudio-r-base-3.6-centos7 (gcc 4.8.5): SUCCESS *without S3* (gcc too old)
* test-r-rstudio-r-base-3.6-centos8 (gcc 8.3.1): FAIL. error building arrow_bundled_dependencies.a because `awssdk_ep-install/lib/libaws-c-event-stream.a: No such file or directory`
* test-r-rstudio-r-base-3.6-opensuse15 (gcc 7.4.1): FAIL. error building arrow_bundled_dependencies.a because `awssdk_ep-install/lib/libaws-c-event-stream.a: No such file or directory`
* test-r-rstudio-r-base-3.6-opensuse42 (gcc 4.8): SUCCESS *without S3* (gcc too old)
I'm trying to reproduce the arrow_bundled_dependencies issue locally. I have no idea how to handle `__cpu_model`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703558823
We can complete #7997 after we merge this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703161901
@github-actions crossbow submit test-r-r*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703353449
@github-actions crossbow submit conda-linux-gcc-*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703116509
Revision: be16507148df0201a7c7f290d81138746ca115a3
Submitted crossbow builds: [ursa-labs/crossbow @ actions-590](https://github.com/ursa-labs/crossbow/branches/all?query=actions-590)
|Task|Status|
|----|------|
|test-r-rstudio-r-base-3.6-opensuse15|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-590-azure-test-r-rstudio-r-base-3.6-opensuse15)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-702855212
@github-actions crossbow submit test-r-rstudio-r-base-3.6-bionic
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-702486308
@github-actions crossbow submit test-r-r*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-700977427
https://issues.apache.org/jira/browse/ARROW-10068
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703335296
Revision: 4056ea0064d42ad932c09d331241c60ab68e7097
Submitted crossbow builds: [ursa-labs/crossbow @ actions-593](https://github.com/ursa-labs/crossbow/branches/all?query=actions-593)
|Task|Status|
|----|------|
|centos-6-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-593-github-centos-6-amd64)|
|centos-7-aarch64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|centos-7-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-593-github-centos-7-amd64)|
|centos-8-aarch64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|centos-8-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-593-github-centos-8-amd64)|
|conda-clean|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-conda-clean)|
|conda-linux-gcc-py36-aarch64|[](https://cloud.drone.io/ursa-labs/crossbow)|
|conda-linux-gcc-py36-cpu|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-conda-linux-gcc-py36-cpu)|
|conda-linux-gcc-py36-cuda|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-conda-linux-gcc-py36-cuda)|
|conda-linux-gcc-py37-aarch64|[](https://cloud.drone.io/ursa-labs/crossbow)|
|conda-linux-gcc-py37-cpu|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-conda-linux-gcc-py37-cpu)|
|conda-linux-gcc-py37-cuda|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-conda-linux-gcc-py37-cuda)|
|conda-linux-gcc-py38-aarch64|[](https://cloud.drone.io/ursa-labs/crossbow)|
|conda-linux-gcc-py38-cpu|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-conda-linux-gcc-py38-cpu)|
|conda-linux-gcc-py38-cuda|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-conda-linux-gcc-py38-cuda)|
|conda-osx-clang-py36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-conda-osx-clang-py36)|
|conda-osx-clang-py37|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-conda-osx-clang-py37)|
|conda-osx-clang-py38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-conda-osx-clang-py38)|
|conda-win-vs2017-py36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-conda-win-vs2017-py36)|
|conda-win-vs2017-py37|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-conda-win-vs2017-py37)|
|conda-win-vs2017-py38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-conda-win-vs2017-py38)|
|debian-buster-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-593-github-debian-buster-amd64)|
|debian-buster-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|debian-stretch-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-593-github-debian-stretch-amd64)|
|debian-stretch-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|example-cpp-minimal-build-static|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-593-github-example-cpp-minimal-build-static)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-593-github-example-cpp-minimal-build-static-system-dependency)|
|gandiva-jar-osx|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|gandiva-jar-xenial|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|homebrew-cpp|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|homebrew-r-autobrew|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|nuget|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-593-github-nuget)|
|test-conda-cpp|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-593-github-test-conda-cpp)|
|test-conda-cpp-valgrind|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-593-github-test-conda-cpp-valgrind)|
|test-conda-python-3.6|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-593-github-test-conda-python-3.6)|
|test-conda-python-3.6-pandas-0.23|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-593-github-test-conda-python-3.6-pandas-0.23)|
|test-conda-python-3.7|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-593-github-test-conda-python-3.7)|
|test-conda-python-3.7-dask-latest|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-593-github-test-conda-python-3.7-dask-latest)|
|test-conda-python-3.7-hdfs-2.9.2|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-593-github-test-conda-python-3.7-hdfs-2.9.2)|
|test-conda-python-3.7-kartothek-latest|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-593-github-test-conda-python-3.7-kartothek-latest)|
|test-conda-python-3.7-kartothek-master|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-593-github-test-conda-python-3.7-kartothek-master)|
|test-conda-python-3.7-pandas-latest|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-593-github-test-conda-python-3.7-pandas-latest)|
|test-conda-python-3.7-pandas-master|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-593-github-test-conda-python-3.7-pandas-master)|
|test-conda-python-3.7-spark-branch-3.0|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-593-github-test-conda-python-3.7-spark-branch-3.0)|
|test-conda-python-3.7-turbodbc-latest|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-593-github-test-conda-python-3.7-turbodbc-latest)|
|test-conda-python-3.7-turbodbc-master|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-593-github-test-conda-python-3.7-turbodbc-master)|
|test-conda-python-3.8|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-593-github-test-conda-python-3.8)|
|test-conda-python-3.8-dask-master|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-593-github-test-conda-python-3.8-dask-master)|
|test-conda-python-3.8-jpype|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-593-github-test-conda-python-3.8-jpype)|
|test-conda-python-3.8-pandas-latest|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-593-github-test-conda-python-3.8-pandas-latest)|
|test-conda-python-3.8-spark-master|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-593-github-test-conda-python-3.8-spark-master)|
|test-conda-r-4.0|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-593-github-test-conda-r-4.0)|
|test-debian-10-cpp|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-593-circle-test-debian-10-cpp)|
|test-debian-10-go-1.12|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-test-debian-10-go-1.12)|
|test-debian-10-python-3|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-test-debian-10-python-3)|
|test-debian-c-glib|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-593-circle-test-debian-c-glib)|
|test-debian-ruby|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-593-circle-test-debian-ruby)|
|test-fedora-32-cpp|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-593-circle-test-fedora-32-cpp)|
|test-fedora-32-python-3|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-test-fedora-32-python-3)|
|test-r-linux-as-cran|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-593-github-test-r-linux-as-cran)|
|test-r-rhub-ubuntu-gcc-release|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-test-r-rhub-ubuntu-gcc-release)|
|test-r-rocker-r-base-latest|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-test-r-rocker-r-base-latest)|
|test-r-rstudio-r-base-3.6-bionic|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-test-r-rstudio-r-base-3.6-bionic)|
|test-r-rstudio-r-base-3.6-centos6|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-test-r-rstudio-r-base-3.6-centos6)|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-test-r-rstudio-r-base-3.6-centos8)|
|test-r-rstudio-r-base-3.6-opensuse15|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-test-r-rstudio-r-base-3.6-opensuse15)|
|test-r-rstudio-r-base-3.6-opensuse42|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-test-r-rstudio-r-base-3.6-opensuse42)|
|test-ubuntu-16.04-cpp|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-593-circle-test-ubuntu-16.04-cpp)|
|test-ubuntu-18.04-cpp|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-593-circle-test-ubuntu-18.04-cpp)|
|test-ubuntu-18.04-cpp-cmake32|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-593-circle-test-ubuntu-18.04-cpp-cmake32)|
|test-ubuntu-18.04-cpp-release|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-593-circle-test-ubuntu-18.04-cpp-release)|
|test-ubuntu-18.04-cpp-static|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-593-circle-test-ubuntu-18.04-cpp-static)|
|test-ubuntu-18.04-docs|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-test-ubuntu-18.04-docs)|
|test-ubuntu-18.04-python-3|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-test-ubuntu-18.04-python-3)|
|test-ubuntu-18.04-r-sanitizer|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-test-ubuntu-18.04-r-sanitizer)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-593-github-test-ubuntu-20.04-cpp)|
|test-ubuntu-20.04-cpp-14|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-593-github-test-ubuntu-20.04-cpp-14)|
|test-ubuntu-20.04-cpp-17|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-593-github-test-ubuntu-20.04-cpp-17)|
|test-ubuntu-c-glib|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-593-circle-test-ubuntu-c-glib)|
|test-ubuntu-ruby|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-test-ubuntu-ruby)|
|ubuntu-bionic-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-593-github-ubuntu-bionic-amd64)|
|ubuntu-bionic-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|ubuntu-focal-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-593-github-ubuntu-focal-amd64)|
|ubuntu-focal-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|ubuntu-xenial-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-593-github-ubuntu-xenial-amd64)|
|ubuntu-xenial-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-manylinux1-cp35m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-wheel-manylinux1-cp35m)|
|wheel-manylinux1-cp36m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-wheel-manylinux1-cp36m)|
|wheel-manylinux1-cp37m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-wheel-manylinux1-cp37m)|
|wheel-manylinux1-cp38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-wheel-manylinux1-cp38)|
|wheel-manylinux2010-cp35m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-wheel-manylinux2010-cp35m)|
|wheel-manylinux2010-cp36m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-wheel-manylinux2010-cp36m)|
|wheel-manylinux2010-cp37m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-wheel-manylinux2010-cp37m)|
|wheel-manylinux2010-cp38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-wheel-manylinux2010-cp38)|
|wheel-manylinux2014-cp35m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-wheel-manylinux2014-cp35m)|
|wheel-manylinux2014-cp36m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-wheel-manylinux2014-cp36m)|
|wheel-manylinux2014-cp37m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-wheel-manylinux2014-cp37m)|
|wheel-manylinux2014-cp38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-593-azure-wheel-manylinux2014-cp38)|
|wheel-osx-cp35m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-cp36m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-cp37m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-cp38|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-win-cp35m|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
|wheel-win-cp36m|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
|wheel-win-cp37m|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
|wheel-win-cp38|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703121861
Lol, @pitrou reported this over a year ago: https://github.com/aws/aws-sdk-cpp/issues/1215
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#discussion_r497075796
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -2630,46 +2628,101 @@ macro(build_awssdk)
endif()
set(AWSSDK_CMAKE_ARGS
- -DCMAKE_BUILD_TYPE=Release
+ -DCMAKE_BUILD_TYPE=release
+ -DMINIMIZE_SIZE=on
+ -DBUILD_ONLY=config\\$<SEMICOLON>s3\\$<SEMICOLON>transfer\\$<SEMICOLON>identity-management\\$<SEMICOLON>sts
-DCMAKE_INSTALL_LIBDIR=lib
- -DBUILD_ONLY=s3;core;config;identity-management;sts
-DENABLE_UNITY_BUILD=on
+ -DBUILD_SHARED_LIBS=off
-DENABLE_TESTING=off
"-DCMAKE_C_FLAGS=${EP_C_FLAGS}"
"-DCMAKE_INSTALL_PREFIX=${AWSSDK_PREFIX}")
- set(
- AWSSDK_CORE_SHARED_LIB
- "${AWSSDK_PREFIX}/lib/${CMAKE_SHARED_LIBRARY_PREFIX}aws-cpp-sdk-core${CMAKE_SHARED_LIBRARY_SUFFIX}"
- )
- set(
- AWSSDK_S3_SHARED_LIB
- "${AWSSDK_PREFIX}/lib/${CMAKE_SHARED_LIBRARY_PREFIX}aws-cpp-sdk-s3${CMAKE_SHARED_LIBRARY_SUFFIX}"
- )
- set(
- AWSSDK_IAM_SHARED_LIB
- "${AWSSDK_PREFIX}/lib/${CMAKE_SHARED_LIBRARY_PREFIX}aws-cpp-sdk-identity-management${CMAKE_SHARED_LIBRARY_SUFFIX}"
- )
- set(
- AWSSDK_STS_SHARED_LIB
- "${AWSSDK_PREFIX}/lib/${CMAKE_SHARED_LIBRARY_PREFIX}aws-cpp-sdk-sts${CMAKE_SHARED_LIBRARY_SUFFIX}"
- )
- set(AWSSDK_SHARED_LIBS "${AWSSDK_CORE_SHARED_LIB}" "${AWSSDK_S3_SHARED_LIB}"
- "${AWSSDK_IAM_SHARED_LIB}" "${AWSSDK_STS_SHARED_LIB}")
+ set(AWSSDK_COMMON_STATIC_LIB "${AWSSDK_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}aws-c-common${CMAKE_STATIC_LIBRARY_SUFFIX}")
+ set(AWSSDK_CHECKSUMS_STATIC_LIB "${AWSSDK_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}aws-checksums${CMAKE_STATIC_LIBRARY_SUFFIX}")
+ set(AWSSDK_ES_STATIC_LIB "${AWSSDK_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}aws-c-event-stream${CMAKE_STATIC_LIBRARY_SUFFIX}")
+ set(AWSSDK_CORE_STATIC_LIB "${AWSSDK_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}aws-cpp-sdk-core${CMAKE_STATIC_LIBRARY_SUFFIX}")
+ set(AWSSDK_S3_STATIC_LIB "${AWSSDK_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}aws-cpp-sdk-s3${CMAKE_STATIC_LIBRARY_SUFFIX}")
+ set(AWSSDK_COG_STATIC_LIB "${AWSSDK_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}aws-cpp-sdk-cognito-identity${CMAKE_STATIC_LIBRARY_SUFFIX}")
+ set(AWSSDK_IAM_STATIC_LIB "${AWSSDK_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}aws-cpp-sdk-identity-management${CMAKE_STATIC_LIBRARY_SUFFIX}")
+ set(AWSSDK_STS_STATIC_LIB "${AWSSDK_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}aws-cpp-sdk-sts${CMAKE_STATIC_LIBRARY_SUFFIX}")
+
+ set(AWSSDK_STATIC_LIBS "${AWSSDK_COG_STATIC_LIB}" "${AWSSDK_CHECKSUMS_STATIC_LIB}" "${AWSSDK_COMMON_STATIC_LIB}" "${AWSSDK_ES_STATIC_LIB}" "${AWSSDK_CORE_STATIC_LIB}" "${AWSSDK_S3_STATIC_LIB}" "${AWSSDK_IAM_STATIC_LIB}" "${AWSSDK_STS_STATIC_LIB}")
externalproject_add(awssdk_ep
${EP_LOG_OPTIONS}
URL ${AWSSDK_SOURCE_URL}
CMAKE_ARGS ${AWSSDK_CMAKE_ARGS}
- BUILD_BYPRODUCTS ${AWSSDK_SHARED_LIBS})
+ BUILD_BYPRODUCTS ${AWSSDK_STATIC_LIBS})
file(MAKE_DIRECTORY ${AWSSDK_INCLUDE_DIR})
+ add_library(AWS::aws-checksums STATIC IMPORTED)
+ set_target_properties(AWS::aws-checksums
+ PROPERTIES IMPORTED_LOCATION "${AWSSDK_CHECKSUMS_STATIC_LIB}"
+ INTERFACE_INCLUDE_DIRECTORIES
+ "${AWSSDK_INCLUDE_DIR}")
+
+ add_library(AWS::aws-c-common STATIC IMPORTED)
+ set_target_properties(AWS::aws-c-common
+ PROPERTIES IMPORTED_LOCATION "${AWSSDK_COMMON_STATIC_LIB}"
+ INTERFACE_INCLUDE_DIRECTORIES
+ "${AWSSDK_INCLUDE_DIR}")
+
+ add_library(AWS::aws-c-event-stream STATIC IMPORTED)
+ set_target_properties(AWS::aws-c-event-stream
+ PROPERTIES IMPORTED_LOCATION "${AWSSDK_ES_STATIC_LIB}"
+ INTERFACE_INCLUDE_DIRECTORIES
+ "${AWSSDK_INCLUDE_DIR}")
+
+ add_library(AWS::aws-cpp-sdk-core STATIC IMPORTED)
+ set_target_properties(AWS::aws-cpp-sdk-core
+ PROPERTIES IMPORTED_LOCATION "${AWSSDK_CORE_STATIC_LIB}"
+ INTERFACE_INCLUDE_DIRECTORIES
+ "${AWSSDK_INCLUDE_DIR}")
+
+ add_library(AWS::aws-cpp-sdk-s3 STATIC IMPORTED)
+ set_target_properties(AWS::aws-cpp-sdk-s3
+ PROPERTIES IMPORTED_LOCATION "${AWSSDK_S3_STATIC_LIB}"
+ INTERFACE_INCLUDE_DIRECTORIES
+ "${AWSSDK_INCLUDE_DIR}")
+
+ add_library(AWS::aws-cpp-sdk-cognito-identity STATIC IMPORTED)
+ set_target_properties(AWS::aws-cpp-sdk-cognito-identity
+ PROPERTIES IMPORTED_LOCATION "${AWSSDK_COG_STATIC_LIB}"
+ INTERFACE_INCLUDE_DIRECTORIES
+ "${AWSSDK_INCLUDE_DIR}")
+
+ add_library(AWS::aws-cpp-sdk-identity-management STATIC IMPORTED)
+ set_target_properties(AWS::aws-cpp-sdk-identity-management
+ PROPERTIES IMPORTED_LOCATION "${AWSSDK_IAM_STATIC_LIB}"
+ INTERFACE_INCLUDE_DIRECTORIES
+ "${AWSSDK_INCLUDE_DIR}")
+
+ add_library(AWS::aws-cpp-sdk-sts STATIC IMPORTED)
+ set_target_properties(AWS::aws-cpp-sdk-sts
+ PROPERTIES IMPORTED_LOCATION "${AWSSDK_STS_STATIC_LIB}"
+ INTERFACE_INCLUDE_DIRECTORIES
+ "${AWSSDK_INCLUDE_DIR}")
+
+ # on linux and macos curl seems to be required
+ find_package(CURL REQUIRED)
+
add_dependencies(toolchain awssdk_ep)
- set(AWSSDK_LINK_LIBRARIES ${AWSSDK_SHARED_LIBS})
+ # list(APPEND ARROW_BUNDLED_STATIC_LIBS AWSSDK)
+ set(AWSSDK_LINK_LIBRARIES
+ AWS::aws-cpp-sdk-identity-management
Review comment:
Note that `AWS::aws-cpp-sdk-config` wasn't required although we look for it find_package components.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-702983569
Current R Linux static build status (using shared libs for curl and openssl/crypto, provided by the system):
* test-r-rhub-ubuntu-gcc-release (ubuntu 16.04, gcc 5.4.0): FAIL. C++ build with S3 succeeds but R package link error: `undefined symbol: __cpu_model`
* test-r-rocker-r-base-latest (debian:testing, gcc 9.3.0): SUCCESS with S3
* test-r-rstudio-r-base-3.6-bionic (ubuntu 18.04, gcc 7.5.0): SUCCESS with S3
* test-r-rstudio-r-base-3.6-centos6 (gcc 8.3.1): FAIL because system openssl is stale: `Found unsuitable version "1.0.1e", but required is at least "1.0.2"`
* test-r-rstudio-r-base-3.6-centos7 (gcc 4.8.5): SUCCESS *without S3* (gcc too old)
* test-r-rstudio-r-base-3.6-centos8 (gcc 8.3.1): FAIL `(missing: OPENSSL_CRYPTO_LIBRARY) (found suitable version "1.1.1c", minimum required is "1.0.2")`
* test-r-rstudio-r-base-3.6-opensuse15 (gcc 7.4.1): FAIL `(missing: OPENSSL_CRYPTO_LIBRARY) (found suitable version "1.1.0i", minimum required is "1.0.2")`
* test-r-rstudio-r-base-3.6-opensuse42 (gcc 4.8): SUCCESS *without S3* (gcc too old)
Summary: 2 success with S3, 2 successfully built without S3 because it detected that gcc was too old, 2 fail because they are finding openssl but not crypto for some reason, 1 fails because it has openssl but the version provided by the package manager is too old, one fails with `undefined symbol: __cpu_model` (a gcc 5 bug?).
Among the reasons this is frustrating:
* I've installed openssl but it says it can't find it (sometimes); I've installed it from the system package manager but it's still too old; these are both easily solvable by bundling openssl like we already do in the wheels, but I've gotten strong pushback on that.
* I've tried to add logic in the R build script to detect whether we can build aws-sdk-cpp (https://github.com/apache/arrow/pull/8304/files#diff-3875fa5e75833c426b36487b25892bd8R370-R398) but that's apparently not enough to catch these deviant (yet common) cases. It would be nice to move this logic to cmake, an `ARROW_S3=PLEASE_IF_YOU_CAN` option: is there objection to that?
* Given how fragile this is, I'm fearing the onslaught of bug reports after the release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson closed pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson closed pull request #8304:
URL: https://github.com/apache/arrow/pull/8304
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-702441782
Revision: 992cb382c84169babf76d85a502c4ec8a16979d8
Submitted crossbow builds: [ursa-labs/crossbow @ actions-575](https://github.com/ursa-labs/crossbow/branches/all?query=actions-575)
|Task|Status|
|----|------|
|test-r-rstudio-r-base-3.6-bionic|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-575-azure-test-r-rstudio-r-base-3.6-bionic)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-702239836
The latest R failures from the CentOS 7 builds are compiler warnings being converted to errors in the awssdk_ep. As it turns out, [aws-sdk-cpp requires gcc >= 4.9](https://github.com/aws/aws-sdk-cpp#minimum-requirements), and these builds are on 4.8. So somewhere we're going to need to add a `if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS "4.9")` check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-702805412
@github-actions crossbow submit test-r-rstudio-r-base-3.6-bionic
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#discussion_r497044090
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -2630,46 +2628,101 @@ macro(build_awssdk)
endif()
set(AWSSDK_CMAKE_ARGS
- -DCMAKE_BUILD_TYPE=Release
+ -DCMAKE_BUILD_TYPE=release
+ -DMINIMIZE_SIZE=on
+ -DBUILD_ONLY=config\\$<SEMICOLON>s3\\$<SEMICOLON>transfer\\$<SEMICOLON>identity-management\\$<SEMICOLON>sts
-DCMAKE_INSTALL_LIBDIR=lib
- -DBUILD_ONLY=s3;core;config;identity-management;sts
-DENABLE_UNITY_BUILD=on
+ -DBUILD_SHARED_LIBS=off
-DENABLE_TESTING=off
"-DCMAKE_C_FLAGS=${EP_C_FLAGS}"
"-DCMAKE_INSTALL_PREFIX=${AWSSDK_PREFIX}")
- set(
- AWSSDK_CORE_SHARED_LIB
- "${AWSSDK_PREFIX}/lib/${CMAKE_SHARED_LIBRARY_PREFIX}aws-cpp-sdk-core${CMAKE_SHARED_LIBRARY_SUFFIX}"
- )
- set(
- AWSSDK_S3_SHARED_LIB
- "${AWSSDK_PREFIX}/lib/${CMAKE_SHARED_LIBRARY_PREFIX}aws-cpp-sdk-s3${CMAKE_SHARED_LIBRARY_SUFFIX}"
- )
- set(
- AWSSDK_IAM_SHARED_LIB
- "${AWSSDK_PREFIX}/lib/${CMAKE_SHARED_LIBRARY_PREFIX}aws-cpp-sdk-identity-management${CMAKE_SHARED_LIBRARY_SUFFIX}"
- )
- set(
- AWSSDK_STS_SHARED_LIB
- "${AWSSDK_PREFIX}/lib/${CMAKE_SHARED_LIBRARY_PREFIX}aws-cpp-sdk-sts${CMAKE_SHARED_LIBRARY_SUFFIX}"
- )
- set(AWSSDK_SHARED_LIBS "${AWSSDK_CORE_SHARED_LIB}" "${AWSSDK_S3_SHARED_LIB}"
- "${AWSSDK_IAM_SHARED_LIB}" "${AWSSDK_STS_SHARED_LIB}")
+ set(AWSSDK_COMMON_STATIC_LIB "${AWSSDK_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}aws-c-common${CMAKE_STATIC_LIBRARY_SUFFIX}")
+ set(AWSSDK_CHECKSUMS_STATIC_LIB "${AWSSDK_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}aws-checksums${CMAKE_STATIC_LIBRARY_SUFFIX}")
+ set(AWSSDK_ES_STATIC_LIB "${AWSSDK_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}aws-c-event-stream${CMAKE_STATIC_LIBRARY_SUFFIX}")
+ set(AWSSDK_CORE_STATIC_LIB "${AWSSDK_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}aws-cpp-sdk-core${CMAKE_STATIC_LIBRARY_SUFFIX}")
+ set(AWSSDK_S3_STATIC_LIB "${AWSSDK_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}aws-cpp-sdk-s3${CMAKE_STATIC_LIBRARY_SUFFIX}")
+ set(AWSSDK_COG_STATIC_LIB "${AWSSDK_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}aws-cpp-sdk-cognito-identity${CMAKE_STATIC_LIBRARY_SUFFIX}")
+ set(AWSSDK_IAM_STATIC_LIB "${AWSSDK_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}aws-cpp-sdk-identity-management${CMAKE_STATIC_LIBRARY_SUFFIX}")
+ set(AWSSDK_STS_STATIC_LIB "${AWSSDK_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}aws-cpp-sdk-sts${CMAKE_STATIC_LIBRARY_SUFFIX}")
+
+ set(AWSSDK_STATIC_LIBS "${AWSSDK_COG_STATIC_LIB}" "${AWSSDK_CHECKSUMS_STATIC_LIB}" "${AWSSDK_COMMON_STATIC_LIB}" "${AWSSDK_ES_STATIC_LIB}" "${AWSSDK_CORE_STATIC_LIB}" "${AWSSDK_S3_STATIC_LIB}" "${AWSSDK_IAM_STATIC_LIB}" "${AWSSDK_STS_STATIC_LIB}")
externalproject_add(awssdk_ep
${EP_LOG_OPTIONS}
URL ${AWSSDK_SOURCE_URL}
CMAKE_ARGS ${AWSSDK_CMAKE_ARGS}
- BUILD_BYPRODUCTS ${AWSSDK_SHARED_LIBS})
+ BUILD_BYPRODUCTS ${AWSSDK_STATIC_LIBS})
file(MAKE_DIRECTORY ${AWSSDK_INCLUDE_DIR})
+ add_library(AWS::aws-checksums STATIC IMPORTED)
+ set_target_properties(AWS::aws-checksums
+ PROPERTIES IMPORTED_LOCATION "${AWSSDK_CHECKSUMS_STATIC_LIB}"
+ INTERFACE_INCLUDE_DIRECTORIES
+ "${AWSSDK_INCLUDE_DIR}")
+
+ add_library(AWS::aws-c-common STATIC IMPORTED)
+ set_target_properties(AWS::aws-c-common
+ PROPERTIES IMPORTED_LOCATION "${AWSSDK_COMMON_STATIC_LIB}"
+ INTERFACE_INCLUDE_DIRECTORIES
+ "${AWSSDK_INCLUDE_DIR}")
+
+ add_library(AWS::aws-c-event-stream STATIC IMPORTED)
+ set_target_properties(AWS::aws-c-event-stream
+ PROPERTIES IMPORTED_LOCATION "${AWSSDK_ES_STATIC_LIB}"
+ INTERFACE_INCLUDE_DIRECTORIES
+ "${AWSSDK_INCLUDE_DIR}")
+
+ add_library(AWS::aws-cpp-sdk-core STATIC IMPORTED)
+ set_target_properties(AWS::aws-cpp-sdk-core
+ PROPERTIES IMPORTED_LOCATION "${AWSSDK_CORE_STATIC_LIB}"
+ INTERFACE_INCLUDE_DIRECTORIES
+ "${AWSSDK_INCLUDE_DIR}")
+
+ add_library(AWS::aws-cpp-sdk-s3 STATIC IMPORTED)
+ set_target_properties(AWS::aws-cpp-sdk-s3
+ PROPERTIES IMPORTED_LOCATION "${AWSSDK_S3_STATIC_LIB}"
+ INTERFACE_INCLUDE_DIRECTORIES
+ "${AWSSDK_INCLUDE_DIR}")
+
+ add_library(AWS::aws-cpp-sdk-cognito-identity STATIC IMPORTED)
+ set_target_properties(AWS::aws-cpp-sdk-cognito-identity
+ PROPERTIES IMPORTED_LOCATION "${AWSSDK_COG_STATIC_LIB}"
+ INTERFACE_INCLUDE_DIRECTORIES
+ "${AWSSDK_INCLUDE_DIR}")
+
+ add_library(AWS::aws-cpp-sdk-identity-management STATIC IMPORTED)
+ set_target_properties(AWS::aws-cpp-sdk-identity-management
+ PROPERTIES IMPORTED_LOCATION "${AWSSDK_IAM_STATIC_LIB}"
+ INTERFACE_INCLUDE_DIRECTORIES
+ "${AWSSDK_INCLUDE_DIR}")
+
+ add_library(AWS::aws-cpp-sdk-sts STATIC IMPORTED)
+ set_target_properties(AWS::aws-cpp-sdk-sts
+ PROPERTIES IMPORTED_LOCATION "${AWSSDK_STS_STATIC_LIB}"
+ INTERFACE_INCLUDE_DIRECTORIES
+ "${AWSSDK_INCLUDE_DIR}")
+
+ # on linux and macos curl seems to be required
+ find_package(CURL REQUIRED)
Review comment:
I'm not sure how feasible is this, perhaps we can turn off the curl dependency of AWS. I assume linking against the system curl should be fine rather than compiling curl as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-702857488
Revision: 96283bc0c9d134680783e3df00926d0b972946ba
Submitted crossbow builds: [ursa-labs/crossbow @ actions-579](https://github.com/ursa-labs/crossbow/branches/all?query=actions-579)
|Task|Status|
|----|------|
|test-r-rstudio-r-base-3.6-bionic|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-579-azure-test-r-rstudio-r-base-3.6-bionic)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703832109
@github-actions crossbow submit -g r
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703561235
OK. I closed #7997.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-702464490
Linux:
* We need MinIO for testing S3 filesystem
* There is no package for MinIO in system package manager
* MinIO provides binary only for amd64
* We need to download it in our Dockerfiles for amd64
* We need to build MinIO on non-amd64 platforms such as arm64
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703350489
@github-actions crossbow submit wheel-osx-*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703756989
I am revising the R installation guide to mention S3 support and the required system dependencies. Will push that today.
@kszucs @kou are there other developer guides that need revision here? I still think it's odd that we now have a setup with `ARROW_DEPENDENCY_SOURCE=BUNDLED` but that still requires system dependencies, so I'm guessing there are docs that need to be clarified.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703324197
`undefined symbol: __cpu_model` is caused by aws-c-common.
And it has been fixed by https://github.com/awslabs/aws-c-common/pull/645 .
It means that we can fix it by using the latest aws-c-common. It's easy with my change because we build aws-c-common by ourselves.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703361197
@github-actions crossbow submit wheel-osx-*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-702242977
Revision: 41e2b98e6136a935137061cb3e0292371f989c57
Submitted crossbow builds: [ursa-labs/crossbow @ actions-573](https://github.com/ursa-labs/crossbow/branches/all?query=actions-573)
|Task|Status|
|----|------|
|test-r-linux-as-cran|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-573-github-test-r-linux-as-cran)|
|test-r-rhub-ubuntu-gcc-release|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-573-azure-test-r-rhub-ubuntu-gcc-release)|
|test-r-rocker-r-base-latest|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-573-azure-test-r-rocker-r-base-latest)|
|test-r-rstudio-r-base-3.6-bionic|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-573-azure-test-r-rstudio-r-base-3.6-bionic)|
|test-r-rstudio-r-base-3.6-centos6|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-573-azure-test-r-rstudio-r-base-3.6-centos6)|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-573-azure-test-r-rstudio-r-base-3.6-centos8)|
|test-r-rstudio-r-base-3.6-opensuse15|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-573-azure-test-r-rstudio-r-base-3.6-opensuse15)|
|test-r-rstudio-r-base-3.6-opensuse42|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-573-azure-test-r-rstudio-r-base-3.6-opensuse42)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703905964
https://issues.apache.org/jira/browse/ARROW-10180 for the docs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#discussion_r499510903
##########
File path: docker-compose.yml
##########
@@ -248,6 +248,7 @@ services:
cache_from:
- ${REPO}:${ARCH}-ubuntu-${UBUNTU}-cpp
args:
+ arch: ${ARCH}
Review comment:
We should add this to the cuda image for consistency, although I don't think nvidia ships arm images.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703353330
@github-actions crossbow submit conda-osx-*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703334920
@github-actions crossbow submit -g nightly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703564821
@github-actions crossbow submit test-fedora-32-cpp test-debian-10-cpp test-ubuntu-20.04-cpp
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-702866357
Revision: 96283bc0c9d134680783e3df00926d0b972946ba
Submitted crossbow builds: [ursa-labs/crossbow @ actions-580](https://github.com/ursa-labs/crossbow/branches/all?query=actions-580)
|Task|Status|
|----|------|
|test-r-rhub-ubuntu-gcc-release|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-580-azure-test-r-rhub-ubuntu-gcc-release)|
|test-r-rocker-r-base-latest|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-580-azure-test-r-rocker-r-base-latest)|
|test-r-rstudio-r-base-3.6-bionic|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-580-azure-test-r-rstudio-r-base-3.6-bionic)|
|test-r-rstudio-r-base-3.6-centos6|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-580-azure-test-r-rstudio-r-base-3.6-centos6)|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-580-azure-test-r-rstudio-r-base-3.6-centos8)|
|test-r-rstudio-r-base-3.6-opensuse15|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-580-azure-test-r-rstudio-r-base-3.6-opensuse15)|
|test-r-rstudio-r-base-3.6-opensuse42|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-580-azure-test-r-rstudio-r-base-3.6-opensuse42)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703372366
@xhochy Do you know how to fix the following in conda-linux-gcc-py36-cpu?
https://dev.azure.com/ursa-labs/crossbow/_build/results?buildId=18312&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=d9b15392-e4ce-5e4c-0c8c-b69645229181&l=2205
```text
WARNING (arrow-cpp,lib/libgandiva.so.200.0.0): Needed DSO lib/liborc.so found in ['orc']
WARNING (arrow-cpp,lib/libgandiva.so.200.0.0): .. but ['orc'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-702946137
@github-actions crossbow submit test-r-rstudio-r-base-3.6-opensuse15
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-702450099
Revision: 66593cdf2aeaf67c1b087c4e9d789f8fd35620c8
Submitted crossbow builds: [ursa-labs/crossbow @ actions-576](https://github.com/ursa-labs/crossbow/branches/all?query=actions-576)
|Task|Status|
|----|------|
|test-r-rstudio-r-base-3.6-bionic|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-576-azure-test-r-rstudio-r-base-3.6-bionic)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-702943521
Revision: 66fa1607e4922cb98bed417fa947d5a0b0c7e949
Submitted crossbow builds: [ursa-labs/crossbow @ actions-583](https://github.com/ursa-labs/crossbow/branches/all?query=actions-583)
|Task|Status|
|----|------|
|test-r-rstudio-r-base-3.6-bionic|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-583-azure-test-r-rstudio-r-base-3.6-bionic)|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-583-azure-test-r-rstudio-r-base-3.6-centos8)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] corleyma commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
corleyma commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-702134542
I know that this is not quite related, but since we're looking upstream now... is there any thought to when/if we'll update the AWS SDK version? I ask because as of `1.8.0`, the default credentials resolution, etc, was enhanced to more fully match what you might expect from awscli/boto3.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703001148
Revision: 5d1b6eec6dfcf4ed01b83c3501b72f96e7690bd1
Submitted crossbow builds: [ursa-labs/crossbow @ actions-587](https://github.com/ursa-labs/crossbow/branches/all?query=actions-587)
|Task|Status|
|----|------|
|test-r-rstudio-r-base-3.6-centos6|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-587-azure-test-r-rstudio-r-base-3.6-centos6)|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-587-azure-test-r-rstudio-r-base-3.6-centos8)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703399999
> @xhochy Do you know how to fix the following in conda-linux-gcc-py36-cpu?
>
> https://dev.azure.com/ursa-labs/crossbow/_build/results?buildId=18312&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=d9b15392-e4ce-5e4c-0c8c-b69645229181&l=2205
>
> ```
> WARNING (arrow-cpp,lib/libgandiva.so.200.0.0): Needed DSO lib/liborc.so found in ['orc']
> WARNING (arrow-cpp,lib/libgandiva.so.200.0.0): .. but ['orc'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)
> ```
This has been fixed on master. Sorry.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] corleyma commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
corleyma commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-702136201
> I know that this is not quite related, but since we're looking upstream now... is there any thought to when/if we'll update the AWS SDK version? I ask because as of `1.8.0`, the default credentials resolution, etc, was enhanced to more fully match what you might expect from awscli/boto3.
Actually, ignore me, I see the version change in this PR now. That's exciting! Given these changes it might be worth (at some point) taking another look at how credentials specification is handled to see if there's anything that can be streamlined.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703351062
Revision: 3d4f2efa3a65d98aa200208fa159cb3595c355e6
Submitted crossbow builds: [ursa-labs/crossbow @ actions-594](https://github.com/ursa-labs/crossbow/branches/all?query=actions-594)
|Task|Status|
|----|------|
|wheel-osx-cp35m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-cp36m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-cp37m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-cp38|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703003701
@github-actions crossbow submit test-r-rstudio-r-base-3.6-centos8 test-r-rstudio-r-base-3.6-centos6
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703390095
@github-actions crossbow submit conda-linux-gcc-*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-702959895
Revision: 672e9f9ecf17c7e195f60c0a95e0434e5fe1ed53
Submitted crossbow builds: [ursa-labs/crossbow @ actions-585](https://github.com/ursa-labs/crossbow/branches/all?query=actions-585)
|Task|Status|
|----|------|
|test-r-rhub-ubuntu-gcc-release|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-585-azure-test-r-rhub-ubuntu-gcc-release)|
|test-r-rocker-r-base-latest|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-585-azure-test-r-rocker-r-base-latest)|
|test-r-rstudio-r-base-3.6-bionic|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-585-azure-test-r-rstudio-r-base-3.6-bionic)|
|test-r-rstudio-r-base-3.6-centos6|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-585-azure-test-r-rstudio-r-base-3.6-centos6)|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-585-azure-test-r-rstudio-r-base-3.6-centos8)|
|test-r-rstudio-r-base-3.6-opensuse15|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-585-azure-test-r-rstudio-r-base-3.6-opensuse15)|
|test-r-rstudio-r-base-3.6-opensuse42|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-585-azure-test-r-rstudio-r-base-3.6-opensuse42)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703756710
Revision: 0657942f8b2bb2cfcb6fee8f8c645a481c0816fb
Submitted crossbow builds: [ursa-labs/crossbow @ actions-600](https://github.com/ursa-labs/crossbow/branches/all?query=actions-600)
|Task|Status|
|----|------|
|homebrew-r-autobrew|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|test-conda-r-4.0|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-600-github-test-conda-r-4.0)|
|test-r-linux-as-cran|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-600-github-test-r-linux-as-cran)|
|test-r-rhub-ubuntu-gcc-release|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-600-azure-test-r-rhub-ubuntu-gcc-release)|
|test-r-rocker-r-base-latest|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-600-azure-test-r-rocker-r-base-latest)|
|test-r-rstudio-r-base-3.6-bionic|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-600-azure-test-r-rstudio-r-base-3.6-bionic)|
|test-r-rstudio-r-base-3.6-centos6|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-600-azure-test-r-rstudio-r-base-3.6-centos6)|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-600-azure-test-r-rstudio-r-base-3.6-centos8)|
|test-r-rstudio-r-base-3.6-opensuse15|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-600-azure-test-r-rstudio-r-base-3.6-opensuse15)|
|test-r-rstudio-r-base-3.6-opensuse42|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-600-azure-test-r-rstudio-r-base-3.6-opensuse42)|
|test-ubuntu-18.04-r-sanitizer|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-600-azure-test-ubuntu-18.04-r-sanitizer)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-702942796
@github-actions crossbow submit test-r-rstudio-r-base-3.6-bionic test-r-rstudio-r-base-3.6-centos8
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-702486754
Revision: 485db23ce15ed9e1c25084ebabc698c413e56084
Submitted crossbow builds: [ursa-labs/crossbow @ actions-577](https://github.com/ursa-labs/crossbow/branches/all?query=actions-577)
|Task|Status|
|----|------|
|test-r-rhub-ubuntu-gcc-release|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-577-azure-test-r-rhub-ubuntu-gcc-release)|
|test-r-rocker-r-base-latest|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-577-azure-test-r-rocker-r-base-latest)|
|test-r-rstudio-r-base-3.6-bionic|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-577-azure-test-r-rstudio-r-base-3.6-bionic)|
|test-r-rstudio-r-base-3.6-centos6|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-577-azure-test-r-rstudio-r-base-3.6-centos6)|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-577-azure-test-r-rstudio-r-base-3.6-centos8)|
|test-r-rstudio-r-base-3.6-opensuse15|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-577-azure-test-r-rstudio-r-base-3.6-opensuse15)|
|test-r-rstudio-r-base-3.6-opensuse42|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-577-azure-test-r-rstudio-r-base-3.6-opensuse42)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703116234
@github-actions crossbow submit test-r-rstudio-r-base-3.6-opensuse15
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-702330011
@github-actions crossbow submit test-r-r*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-702241684
@github-actions crossbow submit test-r-*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#discussion_r499509695
##########
File path: ci/docker/debian-10-cpp.dockerfile
##########
@@ -69,7 +70,10 @@ RUN apt-get update -y -q && \
tzdata \
zlib1g-dev && \
apt-get clean && \
- rm -rf /var/lib/apt/lists/*
+ rm -rf /var/lib/apt/lists/* && \
+ wget -O /usr/local/bin/minio \
Review comment:
Thanks!
I didn't notice it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703902680
Thanks!
We have https://arrow.apache.org/docs/developers/cpp/building.html#build-dependency-management for C++.
(I think that updating the documentation can be worked as a follow-up task.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#discussion_r499453766
##########
File path: ci/docker/debian-10-cpp.dockerfile
##########
@@ -69,7 +70,10 @@ RUN apt-get update -y -q && \
tzdata \
zlib1g-dev && \
apt-get clean && \
- rm -rf /var/lib/apt/lists/*
+ rm -rf /var/lib/apt/lists/* && \
+ wget -O /usr/local/bin/minio \
Review comment:
We have an `ci/scripts/install_minio.sh` script which we could reuse here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#discussion_r497038155
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -2630,46 +2628,101 @@ macro(build_awssdk)
endif()
set(AWSSDK_CMAKE_ARGS
- -DCMAKE_BUILD_TYPE=Release
+ -DCMAKE_BUILD_TYPE=release
+ -DMINIMIZE_SIZE=on
+ -DBUILD_ONLY=config\\$<SEMICOLON>s3\\$<SEMICOLON>transfer\\$<SEMICOLON>identity-management\\$<SEMICOLON>sts
-DCMAKE_INSTALL_LIBDIR=lib
- -DBUILD_ONLY=s3;core;config;identity-management;sts
-DENABLE_UNITY_BUILD=on
+ -DBUILD_SHARED_LIBS=off
-DENABLE_TESTING=off
"-DCMAKE_C_FLAGS=${EP_C_FLAGS}"
"-DCMAKE_INSTALL_PREFIX=${AWSSDK_PREFIX}")
- set(
- AWSSDK_CORE_SHARED_LIB
- "${AWSSDK_PREFIX}/lib/${CMAKE_SHARED_LIBRARY_PREFIX}aws-cpp-sdk-core${CMAKE_SHARED_LIBRARY_SUFFIX}"
- )
- set(
- AWSSDK_S3_SHARED_LIB
- "${AWSSDK_PREFIX}/lib/${CMAKE_SHARED_LIBRARY_PREFIX}aws-cpp-sdk-s3${CMAKE_SHARED_LIBRARY_SUFFIX}"
- )
- set(
- AWSSDK_IAM_SHARED_LIB
- "${AWSSDK_PREFIX}/lib/${CMAKE_SHARED_LIBRARY_PREFIX}aws-cpp-sdk-identity-management${CMAKE_SHARED_LIBRARY_SUFFIX}"
- )
- set(
- AWSSDK_STS_SHARED_LIB
- "${AWSSDK_PREFIX}/lib/${CMAKE_SHARED_LIBRARY_PREFIX}aws-cpp-sdk-sts${CMAKE_SHARED_LIBRARY_SUFFIX}"
- )
- set(AWSSDK_SHARED_LIBS "${AWSSDK_CORE_SHARED_LIB}" "${AWSSDK_S3_SHARED_LIB}"
- "${AWSSDK_IAM_SHARED_LIB}" "${AWSSDK_STS_SHARED_LIB}")
+ set(AWSSDK_COMMON_STATIC_LIB "${AWSSDK_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}aws-c-common${CMAKE_STATIC_LIBRARY_SUFFIX}")
+ set(AWSSDK_CHECKSUMS_STATIC_LIB "${AWSSDK_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}aws-checksums${CMAKE_STATIC_LIBRARY_SUFFIX}")
+ set(AWSSDK_ES_STATIC_LIB "${AWSSDK_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}aws-c-event-stream${CMAKE_STATIC_LIBRARY_SUFFIX}")
+ set(AWSSDK_CORE_STATIC_LIB "${AWSSDK_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}aws-cpp-sdk-core${CMAKE_STATIC_LIBRARY_SUFFIX}")
+ set(AWSSDK_S3_STATIC_LIB "${AWSSDK_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}aws-cpp-sdk-s3${CMAKE_STATIC_LIBRARY_SUFFIX}")
+ set(AWSSDK_COG_STATIC_LIB "${AWSSDK_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}aws-cpp-sdk-cognito-identity${CMAKE_STATIC_LIBRARY_SUFFIX}")
+ set(AWSSDK_IAM_STATIC_LIB "${AWSSDK_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}aws-cpp-sdk-identity-management${CMAKE_STATIC_LIBRARY_SUFFIX}")
+ set(AWSSDK_STS_STATIC_LIB "${AWSSDK_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}aws-cpp-sdk-sts${CMAKE_STATIC_LIBRARY_SUFFIX}")
+
+ set(AWSSDK_STATIC_LIBS "${AWSSDK_COG_STATIC_LIB}" "${AWSSDK_CHECKSUMS_STATIC_LIB}" "${AWSSDK_COMMON_STATIC_LIB}" "${AWSSDK_ES_STATIC_LIB}" "${AWSSDK_CORE_STATIC_LIB}" "${AWSSDK_S3_STATIC_LIB}" "${AWSSDK_IAM_STATIC_LIB}" "${AWSSDK_STS_STATIC_LIB}")
externalproject_add(awssdk_ep
${EP_LOG_OPTIONS}
URL ${AWSSDK_SOURCE_URL}
CMAKE_ARGS ${AWSSDK_CMAKE_ARGS}
- BUILD_BYPRODUCTS ${AWSSDK_SHARED_LIBS})
+ BUILD_BYPRODUCTS ${AWSSDK_STATIC_LIBS})
file(MAKE_DIRECTORY ${AWSSDK_INCLUDE_DIR})
+ add_library(AWS::aws-checksums STATIC IMPORTED)
Review comment:
Put these to a loop instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-702946973
Revision: 66fa1607e4922cb98bed417fa947d5a0b0c7e949
Submitted crossbow builds: [ursa-labs/crossbow @ actions-584](https://github.com/ursa-labs/crossbow/branches/all?query=actions-584)
|Task|Status|
|----|------|
|test-r-rstudio-r-base-3.6-opensuse15|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-584-azure-test-r-rstudio-r-base-3.6-opensuse15)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703042966
Revision: 5089cb76106ea909aced4e0db32c0d5e9a512bd3
Submitted crossbow builds: [ursa-labs/crossbow @ actions-589](https://github.com/ursa-labs/crossbow/branches/all?query=actions-589)
|Task|Status|
|----|------|
|test-r-rhub-ubuntu-gcc-release|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-589-azure-test-r-rhub-ubuntu-gcc-release)|
|test-r-rocker-r-base-latest|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-589-azure-test-r-rocker-r-base-latest)|
|test-r-rstudio-r-base-3.6-bionic|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-589-azure-test-r-rstudio-r-base-3.6-bionic)|
|test-r-rstudio-r-base-3.6-centos6|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-589-azure-test-r-rstudio-r-base-3.6-centos6)|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-589-azure-test-r-rstudio-r-base-3.6-centos8)|
|test-r-rstudio-r-base-3.6-opensuse15|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-589-azure-test-r-rstudio-r-base-3.6-opensuse15)|
|test-r-rstudio-r-base-3.6-opensuse42|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-589-azure-test-r-rstudio-r-base-3.6-opensuse42)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703559516
> We can complete #7997 after we merge this.
I have a working PR https://github.com/apache/arrow/pull/8315 based on this branch. I'm going to rebase that to check the builds are still passing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703332312
Revision: 4056ea0064d42ad932c09d331241c60ab68e7097
Submitted crossbow builds: [ursa-labs/crossbow @ actions-592](https://github.com/ursa-labs/crossbow/branches/all?query=actions-592)
|Task|Status|
|----|------|
|test-r-rhub-ubuntu-gcc-release|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-592-azure-test-r-rhub-ubuntu-gcc-release)|
|test-r-rocker-r-base-latest|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-592-azure-test-r-rocker-r-base-latest)|
|test-r-rstudio-r-base-3.6-bionic|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-592-azure-test-r-rstudio-r-base-3.6-bionic)|
|test-r-rstudio-r-base-3.6-centos6|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-592-azure-test-r-rstudio-r-base-3.6-centos6)|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-592-azure-test-r-rstudio-r-base-3.6-centos8)|
|test-r-rstudio-r-base-3.6-opensuse15|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-592-azure-test-r-rstudio-r-base-3.6-opensuse15)|
|test-r-rstudio-r-base-3.6-opensuse42|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-592-azure-test-r-rstudio-r-base-3.6-opensuse42)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703833299
Revision: 548b6f33b02f651b2c8cf1b43c3db40aba8fb6a6
Submitted crossbow builds: [ursa-labs/crossbow @ actions-601](https://github.com/ursa-labs/crossbow/branches/all?query=actions-601)
|Task|Status|
|----|------|
|homebrew-r-autobrew|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|test-conda-r-4.0|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-601-github-test-conda-r-4.0)|
|test-r-linux-as-cran|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-601-github-test-r-linux-as-cran)|
|test-r-rhub-ubuntu-gcc-release|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-601-azure-test-r-rhub-ubuntu-gcc-release)|
|test-r-rocker-r-base-latest|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-601-azure-test-r-rocker-r-base-latest)|
|test-r-rstudio-r-base-3.6-bionic|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-601-azure-test-r-rstudio-r-base-3.6-bionic)|
|test-r-rstudio-r-base-3.6-centos6|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-601-azure-test-r-rstudio-r-base-3.6-centos6)|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-601-azure-test-r-rstudio-r-base-3.6-centos8)|
|test-r-rstudio-r-base-3.6-opensuse15|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-601-azure-test-r-rstudio-r-base-3.6-opensuse15)|
|test-r-rstudio-r-base-3.6-opensuse42|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-601-azure-test-r-rstudio-r-base-3.6-opensuse42)|
|test-ubuntu-18.04-r-sanitizer|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-601-azure-test-ubuntu-18.04-r-sanitizer)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson edited a comment on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson edited a comment on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703121861
Lol, @pitrou reported this over a year ago: https://github.com/aws/aws-sdk-cpp/issues/1215. Since we're already patching, we can try applying the [patch he made for conda-forge](https://github.com/conda-forge/aws-sdk-cpp-feedstock/blob/c8785c9fe570a6ac68ca01ccdb217243d422f144/recipe/0001-fix-libdir-for-deps.patch).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-702810329
Revision: 841e2f0e3e04c903875bb4196d11a01ac3aacaac
Submitted crossbow builds: [ursa-labs/crossbow @ actions-578](https://github.com/ursa-labs/crossbow/branches/all?query=actions-578)
|Task|Status|
|----|------|
|test-r-rstudio-r-base-3.6-bionic|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-578-azure-test-r-rstudio-r-base-3.6-bionic)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-702330989
Revision: a2f90756b9a0f91e4a7c347720b42b1ade567bcb
Submitted crossbow builds: [ursa-labs/crossbow @ actions-574](https://github.com/ursa-labs/crossbow/branches/all?query=actions-574)
|Task|Status|
|----|------|
|test-r-rhub-ubuntu-gcc-release|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-574-azure-test-r-rhub-ubuntu-gcc-release)|
|test-r-rocker-r-base-latest|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-574-azure-test-r-rocker-r-base-latest)|
|test-r-rstudio-r-base-3.6-bionic|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-574-azure-test-r-rstudio-r-base-3.6-bionic)|
|test-r-rstudio-r-base-3.6-centos6|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-574-azure-test-r-rstudio-r-base-3.6-centos6)|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-574-azure-test-r-rstudio-r-base-3.6-centos8)|
|test-r-rstudio-r-base-3.6-opensuse15|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-574-azure-test-r-rstudio-r-base-3.6-opensuse15)|
|test-r-rstudio-r-base-3.6-opensuse42|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-574-azure-test-r-rstudio-r-base-3.6-opensuse42)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703361507
Revision: 3e6fc9eac7b1c8b4b1477bdac57e2ae311bf3872
Submitted crossbow builds: [ursa-labs/crossbow @ actions-596](https://github.com/ursa-labs/crossbow/branches/all?query=actions-596)
|Task|Status|
|----|------|
|wheel-osx-cp35m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-cp36m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-cp37m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-cp38|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#discussion_r497070736
##########
File path: cpp/thirdparty/versions.txt
##########
@@ -24,7 +24,7 @@
# format).
ARROW_ABSL_BUILD_VERSION=2eba343b51e0923cd3fb919a6abd6120590fc059
-ARROW_AWSSDK_BUILD_VERSION=1.7.160
+ARROW_AWSSDK_BUILD_VERSION=1.8.57
Review comment:
Works with the previous version as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-702928024
@github-actions crossbow submit test-r-r*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-701721407
I got past that particular openssl problem by installing `openssl-static` as @pitrou suggested, though I suspect there's more to the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-701710258
Thanks for sharing the current status.
I'll also take a look the OpenSSL problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703854677
@github-actions crossbow submit test-r-rhub-ubuntu-gcc-release test-r-rocker-r-base-latest
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-702989412
@github-actions crossbow submit test-r-rstudio-r-base-3.6-centos8 test-r-rstudio-r-base-3.6-opensuse15
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703173253
Ok, with that latest patch,
* test-r-rhub-ubuntu-gcc-release (ubuntu 16.04, gcc 5.4.0): FAIL. C++ build with S3 succeeds but R package link error: `undefined symbol: __cpu_model`
* test-r-rocker-r-base-latest (debian:testing, gcc 9.3.0): SUCCESS with S3
* test-r-rstudio-r-base-3.6-bionic (ubuntu 18.04, gcc 7.5.0): SUCCESS with S3
* test-r-rstudio-r-base-3.6-centos6 (gcc 8.3.1): SUCCESS *without S3* (system openssl is 1.0.1e, but we require 1.0.2)
* test-r-rstudio-r-base-3.6-centos7 (gcc 4.8.5): SUCCESS *without S3* (gcc too old)
* test-r-rstudio-r-base-3.6-centos8 (gcc 8.3.1): SUCCESS with S3
* test-r-rstudio-r-base-3.6-opensuse15 (gcc 7.4.1): SUCCESS with S3
* test-r-rstudio-r-base-3.6-opensuse42 (gcc 4.8): SUCCESS *without S3* (gcc too old)
That's 4 successful builds with S3, 3 successful builds but without S3 because system requirements aren't met, and 1 strange link error.
Someone who knows better should revise my cmake hackery in https://github.com/apache/arrow/pull/8304/commits/d3f13d4ca2a63af5d758e900a981c27251a75a90
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703755590
@github-actions crossbow submit -g r
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-702865456
@github-actions crossbow submit test-r-r*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8304: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8304:
URL: https://github.com/apache/arrow/pull/8304#issuecomment-703042816
@github-actions crossbow submit test-r-r*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org