You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2021/07/26 10:10:34 UTC

[GitHub] [brooklyn-server] ahgittin opened a new pull request #1212: persist the actual types of relationships if not standard ones

ahgittin opened a new pull request #1212:
URL: https://github.com/apache/brooklyn-server/pull/1212


   this allows properties etc on extension of relationships to be persisted and rebinded


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [brooklyn-server] asfgit closed pull request #1212: persist the actual types of relationships if not standard ones

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1212:
URL: https://github.com/apache/brooklyn-server/pull/1212


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [brooklyn-server] ahgittin commented on pull request #1212: persist the actual types of relationships if not standard ones

Posted by GitBox <gi...@apache.org>.
ahgittin commented on pull request #1212:
URL: https://github.com/apache/brooklyn-server/pull/1212#issuecomment-886568808


   Without this, Brooklyn only persists the name of relationship types.  This works fine if all relationship types are registered with the management context.  But in some downstream cases ad hoc classes are used as relationship types, sometimes storing properties.  Those relationships were brought back in in a default state.
   
   With this PR we use string names if the relationship type is registered, but if it is not we persist the actual relationship type instance, so it is preserved exactly.  This should ensure relationships are rebinded correctly with no change for the case where it worked, and with the extra metadata for the case where we previously brought them back in a default state.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org