You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by gi...@git.apache.org on 2017/09/08 22:20:16 UTC

[GitHub] xrmx commented on a change in pull request #3438: Feature: Implementing incremental search for a column values

xrmx commented on a change in pull request #3438: Feature: Implementing incremental search for a column values 
URL: https://github.com/apache/incubator-superset/pull/3438#discussion_r137901274
 
 

 ##########
 File path: superset/connectors/sqla/models.py
 ##########
 @@ -285,7 +286,7 @@ def data(self):
             d['time_grain_sqla'] = grains
         return d
 
-    def values_for_column(self, column_name, limit=10000):
+    def values_for_column(self, column_name, limit=10000, filter=None):
 
 Review comment:
   filter is a builtin in python, maybe better use another name?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services