You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "Stephen Mallette (Jira)" <ji...@apache.org> on 2021/04/28 19:08:00 UTC

[jira] [Assigned] (TINKERPOP-1339) Make Step.id() generation faster and simpler

     [ https://issues.apache.org/jira/browse/TINKERPOP-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stephen Mallette reassigned TINKERPOP-1339:
-------------------------------------------

    Assignee:     (was: Daniel Kuppitz)

> Make Step.id() generation faster and simpler
> --------------------------------------------
>
>                 Key: TINKERPOP-1339
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1339
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.2.0-incubating
>            Reporter: Marko A. Rodriguez
>            Priority: Major
>              Labels: breaking
>
> There is a class called {{StepPosition}} that is smart about creating unique ids for steps. Unique, deterministic creation of step ids is important. However, what we have now is expensive. When I original did this, I created an string ID scheme where you could find your location in the traversal, by the id "[0:[1:[2:3]]]" (first step of the root traversal is a traversal parent -- the third step of the second traversal). Why I did it like this I don't know why??! ... Instead, I think we can make things both faster and simpler:
> 1. Change {{Step.id()}} to an integer, not a String.
> 2. Step id labeling is simply walking the traversal tree in a deterministic depth first manner and incrementing a {{nextId++}} counter.
> We can do 2 without 1 and it would not be a breaking change.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)