You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@issues.apache.org on 2010/08/08 21:07:40 UTC

[Bug 6477] New: sa-update contains path of build-environment

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6477

           Summary: sa-update contains path of build-environment
           Product: Spamassassin
           Version: 3.3.1
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Building & Packaging
        AssignedTo: dev@spamassassin.apache.org
        ReportedBy: sca@andreasschulze.de


after packaging SA for debian
sa-update contains the path of the build-environment

the patch fixes that ( for me )

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6477] sa-update contains path of build-environment

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6477

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|Undefined                   |3.3.2

--- Comment #2 from Mark Martinec <Ma...@ijs.si> 2011-05-18 12:45:43 UTC ---
> Created attachment 4798 [details]
> patch to make sa-update contain correct path

Not sure I understand the issue.
The patch drops a dependency of sa-update on build_rules:

- sa-update: sa-update.raw build_rules
+ sa-update: sa-update.raw

which is probably fine, but as far as I can see
it makes no difference on the produced and installed sa-update.

So what is the actual problem being solved here?

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6477] sa-update contains path of build-environment

Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6477

--- Comment #1 from sca@andreasschulze.de 2010-08-08 15:24:51 UTC ---
Created an attachment (id=4798)
 --> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4798)
patch to make sa-update contain correct path

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6477] sa-update contains path of build-environment

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6477

sca@andreasschulze.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.3.1                       |3.3.2

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6477] sa-update contains path of build-environment

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6477

Kevin A. McGrail <km...@pccc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WORKSFORME

--- Comment #5 from Kevin A. McGrail <km...@pccc.com> 2011-11-01 20:01:01 UTC ---
Closing based on the inability to replicate.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6477] sa-update contains path of build-environment

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6477

Kevin A. McGrail <km...@pccc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kmcgrail@pccc.com

--- Comment #4 from Kevin A. McGrail <km...@pccc.com> 2011-05-31 22:09:22 UTC ---
(In reply to comment #3)
> I just retried building 3.3.2.rc2 with and without the patch.
> 
> without, depending on build_rules,
>   sa-update contains paths only used by my buildsytem
> with patch, not depending on build_rules, sa-update looks normal.
> 
> looking info Makefile.pl, sa-update is the only target depending on
> build_rules...
> 
> Andras

OK, so I too 3.3.1, ran make.

took the resulting sa-update and named it sa-update.prev

then ran make clean and edited the Makefile.PL to remove build_rules and ran
make again.

comparing the sa-updates that result, they are identical.

Repeating with 3.3.2-rc2, i have the exact same result. 

In short, sa-update isn't changed.

According to a TODO in the Makefile.PL, build_rules is called on purpose with
sa-update.

Can you run diffs on the sa-update to show us what is changing?

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6477] sa-update contains path of build-environment

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6477

sca@andreasschulze.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sca@andreasschulze.de

--- Comment #3 from sca@andreasschulze.de 2011-05-31 21:56:09 UTC ---
I just retried building 3.3.2.rc2 with and without the patch.

without, depending on build_rules,
  sa-update contains paths only used by my buildsytem
with patch, not depending on build_rules, sa-update looks normal.

looking info Makefile.pl, sa-update is the only target depending on
build_rules...

Andras

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.