You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/04/09 07:38:25 UTC
[jira] [Commented] (STORM-1700) Introduce 'whitelist' / 'blacklist'
option to MetricsConsumer
[ https://issues.apache.org/jira/browse/STORM-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15233366#comment-15233366 ]
ASF GitHub Bot commented on STORM-1700:
---------------------------------------
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1324
STORM-1700 Introduce 'whitelist' / 'blacklist' option to MetricsConsumer
> NOTE: This is based on STORM-1698, PR #1322
* Users can set whitelist or blacklist to filter out metrics by name
* if none of them specified (by default), no metrics are filtered out
* how to match: substring match with regular expression
* use both ^ and $ when you want to match strictly (full string match)
* added unit test
I originally worked based on 1.x-branch and cherry-picked to other branch based on master.
During cherry-picking, though I remove the changeset of common.clj, git said this file is modified.
If we want to remove this change, I'll add commit to fix this.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-1700
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1324.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1324
----
commit e1db0db86eeb3857bc6f958ef0af81d06ff0d9af
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-04-08T04:05:00Z
STORM-1698 Asynchronous MetricsConsumerBolt
* change MetricsConsumerBolt's behavior to asynchronus manner
* to avoid bad side effect of topology
* for details please refer JIRA issue: https://issues.apache.org/jira/browse/STORM-1698
commit 960fe8aeb6ea22523c2516b6fc79f61f7ae0d387
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-04-09T05:11:20Z
STORM-1700 Introduce 'whitelist' / 'blacklist' option to MetricsConsumer
* Users can set whitelist or blacklist to filter out metrics by name
* if none of them specified (by default), no metrics are filtered out
* how to match: substring match with regular expression
* use both ^ and $ when you want to match strictly (full string match)
* added unit test
----
> Introduce 'whitelist' / 'blacklist' option to MetricsConsumer
> -------------------------------------------------------------
>
> Key: STORM-1700
> URL: https://issues.apache.org/jira/browse/STORM-1700
> Project: Apache Storm
> Issue Type: Sub-task
> Components: storm-core
> Affects Versions: 1.0.0, 2.0.0
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
>
> Storm provides various metrics by default, and so on some external modules (storm-kafka).
> When we register MetricsConsumer, MetricsConsumer should handle all of metrics. If MetricsConsumer cannot keep up with these metrics, only way to keep up is increasing parallelism, which seems limited. Furthermore, some users don't want to care about some metrics since unintended metrics will fill external storage.
> Though MetricsConsumer itself can filter metrics by name, it would be better to support filter by Storm side. It will reduce the redundant works for Storm community.
> If we provide filter options, it would be great.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)