You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/18 03:56:58 UTC

[GitHub] [doris] Jibing-Li commented on a diff in pull request #13363: [Improvement](multi-catalog)Support refresh external catalog.

Jibing-Li commented on code in PR #13363:
URL: https://github.com/apache/doris/pull/13363#discussion_r997693270


##########
fe/fe-core/src/main/java/org/apache/doris/analysis/RefreshDbStmt.java:
##########
@@ -34,16 +34,26 @@
 public class RefreshDbStmt extends DdlStmt {
     private static final Logger LOG = LogManager.getLogger(RefreshDbStmt.class);
 
+    private String catalogName;

Review Comment:
   Is it a problem? catalogName could be null, for example when use execute 
   `refresh database db1`
   I think the caller of getCatalogName should handle the null value.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org