[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #382: Remove -x from cibuild.sh call in CI since this will abort the build on first error and we do not want that

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on a change in pull request #382:
URL: https://github.com/apache/incubator-nuttx-apps/pull/382#discussion_r487621138



##########
File path: .github/workflows/build.yml
##########
@@ -180,7 +180,7 @@ jobs:
         with:
           run: |
             cd sources/testing
-            ./cibuild.sh -x testlist/${{matrix.boards}}.dat
+            ./cibuild.sh testlist/${{matrix.boards}}.dat

Review comment:
       @v01d need modfiy these too:
   https://github.com/apache/incubator-nuttx-testing/blob/master/.github/workflows/build.yml#L84
   https://github.com/apache/incubator-nuttx-testing/blob/master/.github/workflows/build.yml#L142
   How about we merge incubator-nuttx-testing into nuttx/tools which will simplify the furture build enhancement a lot. BTW, it's also very helpful for people who want to setupt the local CI infrastructure.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org