[jira] Resolved: (JCR-1841) Workspace.xml can't be loaded if it has a BOM

["Jukka Zitting (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/JCR-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting resolved JCR-1841.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5.0
         Assignee: Jukka Zitting

Good catch, thanks! Patch applied in revision 709142.

> Workspace.xml can't be loaded if it has a BOM
> ---------------------------------------------
>
>                 Key: JCR-1841
>                 URL: https://issues.apache.org/jira/browse/JCR-1841
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: config, jackrabbit-core
>    Affects Versions: core 1.4.6, 1.5.0
>            Reporter: Grégory Joseph
>            Assignee: Jukka Zitting
>             Fix For: 1.5.0
>
>         Attachments: use_inputstream_toload_workspace_config.patch
>
>
> I wondered if there was a specific reason why workspace.xml files are loaded using a FileReader instead of an InputStream in RepositoryConfig?
> If the workspace.xml file has a BOM (which could happen if someone edited the file manually with some misbehaving editor), then it can't be loaded ("Content not allowed in prolog") - here's a little patch that fixes this.
> I left the output part untouched (i.e still using a Writer) - which makes it a little inconsistent - maybe someone with a better knowledge of the JR FileSystem api could fix this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.