[GitHub] [kafka] big-andy-coates commented on pull request #8483: KAFKA-9865: Expose output topic names from TopologyTestDriver

[GitBox <gi...@apache.org>]

big-andy-coates commented on pull request #8483:
URL: https://github.com/apache/kafka/pull/8483#issuecomment-619509083


   Give a man a chance! ;)
   
   On Fri, 24 Apr 2020 at 18:12, Matthias J. Sax <no...@github.com>
   wrote:
   
   > *@mjsax* commented on this pull request.
   > ------------------------------
   >
   > In
   > streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java
   > <https://github.com/apache/kafka/pull/8483#discussion_r414732356>:
   >
   > > @@ -855,6 +856,20 @@ public void advanceWallClockTime(final Duration advance) {
   >          return new TestOutputTopic<>(this, topicName, keyDeserializer, valueDeserializer);
   >      }
   >
   > +    /**
   > +     * Get all the names of all the topics to which records have been output.
   > +     * <p>
   > +     * Call this method after piping the input into the test driver to retrieve the full set of topics the topology
   > +     * produced records to.
   > +     * <p>
   > +     * The returned set of topic names includes changelog, repartition and sink topic names.
   > +     *
   > +     * @return the set of output topic names.
   > +     */
   > +    public final Set<String> getOutputTopicNames() {
   >
   > @big-andy-coates <https://github.com/big-andy-coates> Can you update the
   > method name according to the KIP discussion?
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/kafka/pull/8483#pullrequestreview-400126821>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AB5EE3RWTDDTR7SOKZY5G7LROHB6LANCNFSM4MHZUJ2Q>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org