You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/11/02 04:27:45 UTC
[GitHub] [iceberg] ajantha-bhat opened a new pull request, #6101: Docs: Update spotless apply command for non-default versions
ajantha-bhat opened a new pull request, #6101:
URL: https://github.com/apache/iceberg/pull/6101
While working on https://github.com/apache/iceberg/pull/6096, I learnt that `./gradlew spotlessApply` only works on default versions. I assumed that it works for all the folders. Which was not true.
Hence, updating the document for new users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko merged pull request #6101: Docs: Update spotless apply command for non-default versions
Posted by GitBox <gi...@apache.org>.
Fokko merged PR #6101:
URL: https://github.com/apache/iceberg/pull/6101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on a diff in pull request #6101: Docs: Update spotless apply command for non-default versions
Posted by GitBox <gi...@apache.org>.
nastra commented on code in PR #6101:
URL: https://github.com/apache/iceberg/pull/6101#discussion_r1011395474
##########
README.md:
##########
@@ -58,6 +58,9 @@ Iceberg is built using Gradle with Java 1.8 or Java 11.
* To invoke a build and run tests: `./gradlew build`
* To skip tests: `./gradlew build -x test -x integrationTest`
* To fix code style: `./gradlew spotlessApply`
+ The above command applies to default versions.
+ Need to pass the non-default versions via `-DsparkVersions`, `-DflinkVersions`, `-DhiveVersions` argument.
Review Comment:
```suggestion
To fix code style for non-default versions, the following flags need to be passed: `-DsparkVersions`, `-DflinkVersions`, `-DhiveVersions`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on a diff in pull request #6101: Docs: Update spotless apply command for non-default versions
Posted by GitBox <gi...@apache.org>.
nastra commented on code in PR #6101:
URL: https://github.com/apache/iceberg/pull/6101#discussion_r1011357534
##########
README.md:
##########
@@ -58,6 +58,8 @@ Iceberg is built using Gradle with Java 1.8 or Java 11.
* To invoke a build and run tests: `./gradlew build`
* To skip tests: `./gradlew build -x test -x integrationTest`
* To fix code style: `./gradlew spotlessApply`
+ The above command applies to default versions.
+ Need to pass the non-default versions via `-DsparkVersions`, `-DflinkVersions`, `-DhiveVersions` argument
Review Comment:
you might want to mention an example as well: `./gradlew spotlessApply -DflinkVersions=1.13,1.14,1.15 -DsparkVersions=2.4,3.0,3.1,3.2,3.3 -DhiveVersions=2,3`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] ajantha-bhat commented on a diff in pull request #6101: Docs: Update spotless apply command for non-default versions
Posted by GitBox <gi...@apache.org>.
ajantha-bhat commented on code in PR #6101:
URL: https://github.com/apache/iceberg/pull/6101#discussion_r1011371634
##########
README.md:
##########
@@ -58,6 +58,8 @@ Iceberg is built using Gradle with Java 1.8 or Java 11.
* To invoke a build and run tests: `./gradlew build`
* To skip tests: `./gradlew build -x test -x integrationTest`
* To fix code style: `./gradlew spotlessApply`
+ The above command applies to default versions.
+ Need to pass the non-default versions via `-DsparkVersions`, `-DflinkVersions`, `-DhiveVersions` argument
Review Comment:
I intentionally didn't add the example thinking that we need to modify the `ReadMe.md` each time we change the version number. (when a new version is added or the old version is removed)
But thinking more about it, maybe it is ok to add it.
I have added it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org