You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Sergey Chugunov (Jira)" <ji...@apache.org> on 2021/06/04 07:32:00 UTC

[jira] [Commented] (IGNITE-14824) DirectMessageWriter can write partial message header

    [ https://issues.apache.org/jira/browse/IGNITE-14824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357120#comment-17357120 ] 

Sergey Chugunov commented on IGNITE-14824:
------------------------------------------

[~apolovtcev],

Your patch looks good to me, I approved and merged PR. Thank you for this important fix!

> DirectMessageWriter can write partial message header
> ----------------------------------------------------
>
>                 Key: IGNITE-14824
>                 URL: https://issues.apache.org/jira/browse/IGNITE-14824
>             Project: Ignite
>          Issue Type: Bug
>          Components: networking
>    Affects Versions: 3.0.0-alpha3
>            Reporter: Aleksandr Polovtcev
>            Assignee: Aleksandr Polovtcev
>            Priority: Critical
>             Fix For: 3.0.0-alpha3
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> {{DirectMessageWriter#writeHeader}} writes the message header as two {{short}} values. This may result in problems, when the outgoing buffer only has less 2 or 3 bytes left, in which case only one {{short}} value will be actually sent. Current code does not handle this situation properly, so it will send the whole header again, despite that the first two bytes have already been transferred to the receiving side.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)