You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/10/21 18:40:50 UTC
[GitHub] [solr] epugh opened a new pull request, #1104: SOLR-13626: document the SystemInfoHandler
epugh opened a new pull request, #1104:
URL: https://github.com/apache/solr/pull/1104
https://issues.apache.org/jira/browse/SOLR-13626
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
To create a Jira issue, you will need to create an account there first.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
This is work that was done in the old shared lucene-solr repo https://github.com/apache/lucene-solr/pull/802 by @tonycoz.
Add missing documentation for /admin/info/system which implicit-requesthandlers currently links to a 404
# Solution
Provide some basic documentation.
# Tests
built ref guide
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh merged pull request #1104: SOLR-13626: document the SystemInfoHandler
Posted by GitBox <gi...@apache.org>.
epugh merged PR #1104:
URL: https://github.com/apache/solr/pull/1104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on a diff in pull request #1104: SOLR-13626: document the SystemInfoHandler
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on code in PR #1104:
URL: https://github.com/apache/solr/pull/1104#discussion_r1009650796
##########
solr/solr-ref-guide/modules/configuration-guide/pages/implicit-requesthandlers.adoc:
##########
@@ -121,7 +122,9 @@ Segments:: Return info on last commit generation Lucene index segments.
|`solr/<collection>/admin/segments` |{solr-javadocs}/core/org/apache/solr/handler/admin/SegmentsInfoRequestHandler.html[SegmentsInfoRequestHandler] |`_ADMIN_SEGMENTS`
|===
-System Settings:: Return server statistics and settings.
+System Info:: Return server statistics and settings.
++
+*Documentation*: <<system-info-handler.adoc#system-info-handler,System Info Handler>>
Review Comment:
Look at the dev-docs for the new inter-guide link syntax: https://github.com/apache/solr/blob/main/dev-docs/ref-guide/asciidoc-syntax.adoc#link-to-other-pagessections-of-the-guide
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #1104: SOLR-13626: document the SystemInfoHandler
Posted by GitBox <gi...@apache.org>.
epugh commented on PR #1104:
URL: https://github.com/apache/solr/pull/1104#issuecomment-1287317048
@tonycoz, how would you like to be reference in the Changelog?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #1104: SOLR-13626: document the SystemInfoHandler
Posted by GitBox <gi...@apache.org>.
epugh commented on PR #1104:
URL: https://github.com/apache/solr/pull/1104#issuecomment-1297557561
Thanks @HoustonPutman for the advice... I honestly had gotten frustrated with the build, so your feedback got me moving again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org