You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2017/09/14 21:29:14 UTC
[native-toolchain-CR] Bump LLVM to 3.9.1 and CMake to 3.8.2
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/8075
Change subject: Bump LLVM to 3.9.1 and CMake to 3.8.2
......................................................................
Bump LLVM to 3.9.1 and CMake to 3.8.2
LLVM required a newer CMake version than the previous one, so upgrade
CMake to a recent release.
Testing:
Was able to build on all supported OSes. Also got Impala to build and
pass tests. See https://gerrit.cloudera.org/#/c/7974/
Change-Id: I67e4e3b4e36d7e654adaa9323597902f056a5291
---
M buildall.sh
M init.sh
A source/cmake/cmake-3.8.2-patches/0001-IMPALA-3191.patch
3 files changed, 17 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/75/8075/1
--
To view, visit http://gerrit.cloudera.org:8080/8075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I67e4e3b4e36d7e654adaa9323597902f056a5291
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[native-toolchain-CR] Bump LLVM to 3.9.1 and CMake to 3.8.2
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: Bump LLVM to 3.9.1 and CMake to 3.8.2
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8075/1/source/cmake/cmake-3.8.2-patches/0001-IMPALA-3191.patch
File source/cmake/cmake-3.8.2-patches/0001-IMPALA-3191.patch:
PS1, Line 10: https://cmake.org/Bug/view.php?id=15873
> I can't tell what happened to that bug report? was it resolved in some way?
Looks like it was migrated to https://gitlab.kitware.com/cmake/cmake/issues/15873 - it's still open.
--
To view, visit http://gerrit.cloudera.org:8080/8075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I67e4e3b4e36d7e654adaa9323597902f056a5291
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[native-toolchain-CR] Bump LLVM to 3.9.1 and CMake to 3.8.2
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: Bump LLVM to 3.9.1 and CMake to 3.8.2
......................................................................
Patch Set 1:
I will wait until both the Impala and toolchain changes are +2ed before rebasing and merging together. With the regular Kudu version bumps these coordinated changes rapidly get stale.
--
To view, visit http://gerrit.cloudera.org:8080/8075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I67e4e3b4e36d7e654adaa9323597902f056a5291
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[native-toolchain-CR] Bump LLVM to 3.9.1 and CMake to 3.8.2
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has uploaded a new patch set (#2).
Change subject: Bump LLVM to 3.9.1 and CMake to 3.8.2
......................................................................
Bump LLVM to 3.9.1 and CMake to 3.8.2
LLVM required a newer CMake version than the previous one, so upgrade
CMake to a recent release.
Testing:
Was able to build on all supported OSes. Also got Impala to build and
pass tests. See https://gerrit.cloudera.org/#/c/7974/
Change-Id: I67e4e3b4e36d7e654adaa9323597902f056a5291
---
M buildall.sh
M init.sh
A source/cmake/cmake-3.8.2-patches/0001-IMPALA-3191.patch
3 files changed, 17 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/75/8075/2
--
To view, visit http://gerrit.cloudera.org:8080/8075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I67e4e3b4e36d7e654adaa9323597902f056a5291
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[native-toolchain-CR] Bump LLVM to 3.9.1 and CMake to 3.8.2
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change.
Change subject: Bump LLVM to 3.9.1 and CMake to 3.8.2
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8075/1/source/cmake/cmake-3.8.2-patches/0001-IMPALA-3191.patch
File source/cmake/cmake-3.8.2-patches/0001-IMPALA-3191.patch:
PS1, Line 10: https://cmake.org/Bug/view.php?id=15873
I can't tell what happened to that bug report? was it resolved in some way?
--
To view, visit http://gerrit.cloudera.org:8080/8075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I67e4e3b4e36d7e654adaa9323597902f056a5291
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[native-toolchain-CR] Bump LLVM to 3.9.1 and CMake to 3.8.2
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: Bump LLVM to 3.9.1 and CMake to 3.8.2
......................................................................
Patch Set 2: Verified+1
Successfully built with ID 468-0b4f08e601
--
To view, visit http://gerrit.cloudera.org:8080/8075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I67e4e3b4e36d7e654adaa9323597902f056a5291
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[native-toolchain-CR] Bump LLVM to 3.9.1 and CMake to 3.8.2
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged.
Change subject: Bump LLVM to 3.9.1 and CMake to 3.8.2
......................................................................
Bump LLVM to 3.9.1 and CMake to 3.8.2
LLVM required a newer CMake version than the previous one, so upgrade
CMake to a recent release.
Testing:
Was able to build on all supported OSes. Also got Impala to build and
pass tests. See https://gerrit.cloudera.org/#/c/7974/
Change-Id: I67e4e3b4e36d7e654adaa9323597902f056a5291
---
M buildall.sh
M init.sh
A source/cmake/cmake-3.8.2-patches/0001-IMPALA-3191.patch
3 files changed, 17 insertions(+), 10 deletions(-)
Approvals:
Tim Armstrong: Verified
Dan Hecht: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/8075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I67e4e3b4e36d7e654adaa9323597902f056a5291
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[native-toolchain-CR] Bump LLVM to 3.9.1 and CMake to 3.8.2
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change.
Change subject: Bump LLVM to 3.9.1 and CMake to 3.8.2
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I67e4e3b4e36d7e654adaa9323597902f056a5291
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No