You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/04/06 18:52:58 UTC

[GitHub] [arrow-rs] tustvold opened a new issue, #4029: Field::contains Should Recurse into DataType

tustvold opened a new issue, #4029:
URL: https://github.com/apache/arrow-rs/issues/4029

   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   <!--
   A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] 
   (This section helps Arrow developers understand the context and *why* for this feature, in addition to  the *what*)
   -->
   
   `Field::contains` currently checks for exact equality on `DataType`. For nested fields, this should be relaxed to instead call `Field::contains` or `Fields::contains` as appropriate.
   
   **Describe the solution you'd like**
   <!--
   A clear and concise description of what you want to happen.
   -->
   
   I would like a `DataType::contains` method that behaves similarly to `Fields::contains`, `Schema::contains`, etc... and verifies that non-nested types are exactly equal, whilst using `Field::contains` and `Fields::contains` as appropriate for nested fields such as lists, structs and dictionaries.
   
   **Describe alternatives you've considered**
   <!--
   A clear and concise description of any alternative solutions or features you've considered.
   -->
   
   **Additional context**
   <!--
   Add any other context or screenshots about the feature request here.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] tustvold commented on issue #4029: Field::contains Should Recurse into DataType

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on issue #4029:
URL: https://github.com/apache/arrow-rs/issues/4029#issuecomment-1517888534

   `label_issue.py` automatically added labels {'arrow'} from #4042


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] tustvold closed issue #4029: Field::contains Should Recurse into DataType

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold closed issue #4029: Field::contains Should Recurse into DataType
URL: https://github.com/apache/arrow-rs/issues/4029


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] Weijun-H commented on issue #4029: Field::contains Should Recurse into DataType

Posted by "Weijun-H (via GitHub)" <gi...@apache.org>.
Weijun-H commented on issue #4029:
URL: https://github.com/apache/arrow-rs/issues/4029#issuecomment-1501613865

   I am glad to work on this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org