You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@logging.apache.org by remkop <gi...@git.apache.org> on 2017/04/16 13:28:20 UTC

[GitHub] logging-log4j2 issue #71: [LOG4J2-1874] Add ByteBufferDestionation.write(Byt...

Github user remkop commented on the issue:

    https://github.com/apache/logging-log4j2/pull/71
  
    @leventov Quick update: Started to look at the PR but did not get far yet. I'm taking my time because this is a fairly sensitive area. When converting the OutputStreamAppender and *FileAppenders to the ByteBufferDestination API for the garbage-free epic it took me a few tries to get it right. A complicating factor is that there may be users who subclassed any of these classes, and we don't want to break their stuff. At first glance your proposal does not affect that but I haven't spent enough time with it yet to be sure. (Did all the tests pass for you? I have some environment trouble and haven't been able to try yet.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---