You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by elkangaroo <gi...@git.apache.org> on 2017/03/21 15:39:47 UTC
[GitHub] zeppelin pull request #2173: [ZEPPELIN-2291] Notebook commit dropdown cut-of...
GitHub user elkangaroo opened a pull request:
https://github.com/apache/zeppelin/pull/2173
[ZEPPELIN-2291] Notebook commit dropdown cut-off
### What is this PR for?
When you have a notebook under GIT version control, the dropdown with your commits will be cut-off with no possibility to scroll to older commits (see attached screenshot).
This fixes it by applying a relative max-height and appropriate overflow (similar styles as for the notebooks dropdown in the navigation bar). If the dropdown is longer than max-height, a scrollbar will be shown :)
### What type of PR is it?
Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2291
### How should this be tested?
Create a notebook under version control and make a couple of changes & commits, until the dropdown gets too long to fit on one screen. If everything works as intended, you should now be able to scroll to older commits inside the dropdown.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MyHammer/zeppelin ZEPPELIN-2291-Commit-Dropdown-Scroll
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2173.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2173
----
commit 154cfaa1edb200b76409232268b347a80292244d
Author: Alexander Wenzel <we...@myhammer.de>
Date: 2017-03-21T15:30:09Z
[ZEPPELIN-2291] Fix cut-off revision dropdown
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2173: [ZEPPELIN-2291] Notebook commit dropdown cut-off
Posted by elkangaroo <gi...@git.apache.org>.
Github user elkangaroo commented on the issue:
https://github.com/apache/zeppelin/pull/2173
Hi, I have now swiched on 'zeppelin' repository at https://travis-ci.org/profile.
But I don't see this option:
> And then make sure 'Build pushes' option is enabled in the settings https://travis-ci.org/MyHammer/zeppelin/settings.
How can I trigger CI job again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2173: [ZEPPELIN-2291] Notebook commit dropdown cut-of...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2173
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2173: [ZEPPELIN-2291] Notebook commit dropdown cut-off
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2173
LGTM and merge to master and branch-0.7 if no further comments.
Thanks @elkangaroo for the contribution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2173: [ZEPPELIN-2291] Notebook commit dropdown cut-off
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2173
Looks like travis changed the name of option from "build pushes" to "Build branch updates".
Amend your last commit with `git commit --amend` and do `git push your-remote HEAD --force` will trigger CI job.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---