You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by sunjincheng121 <gi...@git.apache.org> on 2017/05/16 09:35:52 UTC
[GitHub] flink pull request #3920: [FLINK-6597][streaming] Cleanup WindowOperatorTest...
GitHub user sunjincheng121 opened a pull request:
https://github.com/apache/flink/pull/3920
[FLINK-6597][streaming] Cleanup WindowOperatorTest useless imports
Don't miss doing any good thing no matter how insignificant it looks.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-6597][streaming] Cleanup WindowOperatorTest useless imports")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sunjincheng121/flink FLINK-6597-PR
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3920.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3920
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3920: [FLINK-6597][streaming] Cleanup WindowOperatorTest useles...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3920
@greghogan that would make sense to me. Not sure why we excluded the tests in the first place.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3920: [FLINK-6597][streaming] Cleanup WindowOperatorTest useles...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3920
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3920: [FLINK-6597][streaming] Cleanup WindowOperatorTest...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3920
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3920: [FLINK-6597][streaming] Cleanup WindowOperatorTest useles...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3920
@sunjincheng121 thanks for this PR. @fhueske what do you think of enabling checkstyle's `includeTestSourceDirectory`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3920: [FLINK-6597][streaming] Cleanup WindowOperatorTest useles...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3920
Perhaps we should enable checkstyle on test sources when upgrading to the strict checkstyle.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---