[GitHub] [hadoop] iwasakims commented on a diff in pull request #4538: HDFS-16654. Link OpenSSL lib for CMake deps check

[GitBox <gi...@apache.org>]

iwasakims commented on code in PR #4538:
URL: https://github.com/apache/hadoop/pull/4538#discussion_r917275784


##########
hadoop-hdfs-project/hadoop-hdfs-native-client/src/CMakeLists.txt:
##########
@@ -127,7 +127,8 @@ if(OPENSSL_LIBRARY AND OPENSSL_INCLUDE_DIR)
     include(CheckCSourceCompiles)
     set(OLD_CMAKE_REQUIRED_INCLUDES ${CMAKE_REQUIRED_INCLUDES})
     set(CMAKE_REQUIRED_INCLUDES ${OPENSSL_INCLUDE_DIR})
-    check_c_source_compiles("#include \"${OPENSSL_INCLUDE_DIR}/openssl/evp.h\"\nint main(int argc, char **argv) { return !EVP_aes_256_ctr; }" HAS_NEW_ENOUGH_OPENSSL)

Review Comment:
   Users can use OpenSSL installed to non-standard location by specifying properties like `-Dopenssl.lib=/path/to/lib -Dopenssl.include=/path/to/include`. 
   https://github.com/apache/hadoop/blob/9b1d3579b483069d0a211cb0b29c1f25013684dd/hadoop-hdfs-project/hadoop-hdfs-native-client/pom.xml#L221-L223
   
   Does this change break the feature?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org