[Bug 57981] Require a minimum of Java 7

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=57981

--- Comment #25 from Graham Russell <jm...@ham1.co.uk> ---
Felix, thanks again for applying the patches.

Regarding the two bits from patches 2&3 you did not apply:

- the usage of Arrays.asList to simplify filling of a linked list:
-- I don't believe this would add much in the way of memory usage as the
Arrays.asList is O(1) as it just wraps the existing array. I think this is
cleaner code than the for loop.

- and conversion of tests using indexOf to contains:
-- This is a better use of the Java API in my opinion because contains is the
exact intent whereas indexOf checking is code used before 1.5 (when contains
was introduced).

-- 
You are receiving this mail because:
You are the assignee for the bug.