You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by ah...@apache.org on 2021/03/03 07:31:52 UTC
[isis] branch master updated: ISIS-2534: AuthorizorShiro:
regression ... remove assertion
This is an automated email from the ASF dual-hosted git repository.
ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git
The following commit(s) were added to refs/heads/master by this push:
new 5554634 ISIS-2534: AuthorizorShiro: regression ... remove assertion
5554634 is described below
commit 55546340db8a045995b6c50a8cb25e3f3880d8c3
Author: Andi Huber <ah...@apache.org>
AuthorDate: Wed Mar 3 08:31:36 2021 +0100
ISIS-2534: AuthorizorShiro: regression ... remove assertion
are not the same ...
userName
subject.getPrincipal().toString()
---
.../org/apache/isis/security/shiro/authorization/AuthorizorShiro.java | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/security/shiro/src/main/java/org/apache/isis/security/shiro/authorization/AuthorizorShiro.java b/security/shiro/src/main/java/org/apache/isis/security/shiro/authorization/AuthorizorShiro.java
index 6017894..d8ee6b6 100644
--- a/security/shiro/src/main/java/org/apache/isis/security/shiro/authorization/AuthorizorShiro.java
+++ b/security/shiro/src/main/java/org/apache/isis/security/shiro/authorization/AuthorizorShiro.java
@@ -30,7 +30,6 @@ import org.springframework.stereotype.Service;
import org.apache.isis.applib.Identifier;
import org.apache.isis.applib.annotation.OrderPrecedence;
-import org.apache.isis.commons.internal.assertions._Assert;
import org.apache.isis.core.security.authentication.Authentication;
import org.apache.isis.core.security.authentication.Authenticator;
import org.apache.isis.core.security.authorization.Authorizor;
@@ -79,7 +78,7 @@ public class AuthorizorShiro implements Authorizor {
final String permission = asPermissionsString(identifier) + ":" + qualifier;
try {
- _Assert.assertEquals(userName, subject.getPrincipal().toString());
+ //_Assert.assertEquals(userName, subject.getPrincipal().toString()); ... does not work
return subject.isPermitted(permission);
} finally {
IsisPermission.resetVetoedPermissions();