You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/02/17 10:39:32 UTC
[GitHub] [incubator-pekko-http] pjfanning opened a new issue, #68: docs: issue with scala/java links
pjfanning opened a new issue, #68:
URL: https://github.com/apache/incubator-pekko-http/issues/68
In some `.md` files, we have links like:
*introduction.md*
```
See @scala[@ref[JSON Support](common/json-support.md))]@java[@ref[JSON Support](common/json-support.md#jackson-support))] for more information about integration
```
This is being rendered as 2 links with the same name beside each other, when I think the intent is that one shows depending on whether you've chosen Java or Scala.
See https://nightlies.apache.org/pekko/docs/pekko-http/main-snapshot/docs//introduction.html
<img width="704" alt="image" src="https://user-images.githubusercontent.com/11783444/219621596-49a1b927-ebe8-4c98-afb3-095a7dbdb31e.png">
This is just one example. I checked a few more and they have similar issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning commented on issue #68: docs: issue with scala/java links
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #68:
URL: https://github.com/apache/incubator-pekko-http/issues/68#issuecomment-1598963677
this is fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on issue #68: docs: issue with scala/java links
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #68:
URL: https://github.com/apache/incubator-pekko-http/issues/68#issuecomment-1434455611
There was some rendering issues which I noticed were in the original Akka version as well when doing the package rename, was going to fix them in a future PR because I wanted to separate the concerns.
Thanks for making an issue on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on issue #68: docs: issue with scala/java links
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on issue #68:
URL: https://github.com/apache/incubator-pekko-http/issues/68#issuecomment-1434514916
Probably caused by https://github.com/apache/incubator-pekko-sbt-paradox/issues/25
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning commented on issue #68: docs: issue with scala/java links
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #68:
URL: https://github.com/apache/incubator-pekko-http/issues/68#issuecomment-1434453867
@jrudolph @mdedetrich small rendering issue in pekko-http docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on issue #68: docs: issue with scala/java links
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on issue #68:
URL: https://github.com/apache/incubator-pekko-http/issues/68#issuecomment-1451608963
> A possibly separate issue is that in introduction.md, the instructions for using `sbt new akka/akka-http-quickstart-java.g8` are not appearing.
I think this is "as designed". You need to use the switcher on the nav bar to switch to Java and you will get the other instructions. AFAIK only source snippets (`@@snip`) allow "real tabs" that are always shown but not the `@@@ div { .group-scala }` style of creating tabs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning commented on issue #68: docs: issue with scala/java links
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #68:
URL: https://github.com/apache/incubator-pekko-http/issues/68#issuecomment-1450314827
A possibly separate issue is that in introduction.md, the instructions for using `sbt new akka/akka-http-quickstart-java.g8` are not appearing. Only the Scala tab shows - see https://nightlies.apache.org/pekko/docs/pekko-http/main-snapshot/docs/introduction.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning closed issue #68: docs: issue with scala/java links
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning closed issue #68: docs: issue with scala/java links
URL: https://github.com/apache/incubator-pekko-http/issues/68
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on issue #68: docs: issue with scala/java links
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on issue #68:
URL: https://github.com/apache/incubator-pekko-http/issues/68#issuecomment-1434510821
There are probably a few things like that which need to be fixed in the theme.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org