You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Andrzej Bialecki (Jira)" <ji...@apache.org> on 2020/04/22 10:32:00 UTC
[jira] [Comment Edited] (SOLR-14423) static caches in StreamHandler
ought to move to CoreContainer lifecycle
[ https://issues.apache.org/jira/browse/SOLR-14423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089534#comment-17089534 ]
Andrzej Bialecki edited comment on SOLR-14423 at 4/22/20, 10:31 AM:
--------------------------------------------------------------------
{{SolrCloudManager.getObjectCache()}} was implemented for precisely this reason - there was no other place that was related to a "node" concept where we could keep references to node-wide resources. I think it would be fine to make it type-safe in the way you described.
was (Author: ab):
{{SolrCloudManager.getObjectCache()}} was implemented for precisely this reason - there was no other place that was related to a "node" concept where we could keep references to node-wide resources.
> static caches in StreamHandler ought to move to CoreContainer lifecycle
> -----------------------------------------------------------------------
>
> Key: SOLR-14423
> URL: https://issues.apache.org/jira/browse/SOLR-14423
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: streaming expressions
> Reporter: David Smiley
> Priority: Major
>
> StreamHandler (at "/stream") has several statically declared caches. I think this is problematic, such as in testing wherein multiple nodes could be in the same JVM. One of them is more serious -- SolrClientCache which is closed/cleared via a SolrCore close hook. That's bad for performance but also dangerous since another core might want to use one of these clients!
> CC [~jbernste]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org