You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Guillaume Nodet (JIRA)" <ji...@apache.org> on 2012/07/06 12:03:35 UTC
[jira] [Created] (HADOOP-8571) Improve resource cleaning when
shutting down
Guillaume Nodet created HADOOP-8571:
---------------------------------------
Summary: Improve resource cleaning when shutting down
Key: HADOOP-8571
URL: https://issues.apache.org/jira/browse/HADOOP-8571
Project: Hadoop Common
Issue Type: Improvement
Reporter: Guillaume Nodet
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8571) Improve resource cleaning when
shutting down
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407876#comment-13407876 ]
Guillaume Nodet commented on HADOOP-8571:
-----------------------------------------
I've committed a patch in a github fork at
https://github.com/gnodet/hadoop-common/commit/d7a6738429716000376df344ae68ee1a1a630223
> Improve resource cleaning when shutting down
> --------------------------------------------
>
> Key: HADOOP-8571
> URL: https://issues.apache.org/jira/browse/HADOOP-8571
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Guillaume Nodet
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8571) Improve resource cleaning when
shutting down
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408081#comment-13408081 ]
Guillaume Nodet commented on HADOOP-8571:
-----------------------------------------
Yes, I want to first fix the 1.0 branch to be ready for OSGi and then backport everything to trunk.
I'll upload real patches and attach them the usual way (btw, I'm an ASF committer already, so I don't think such a grant is really needed in that case anyway).
Related to the changes, I think the most problematic problem is related to CleanupQueue which is a singleton with a thread wich is never stopped. I think most of the other threads are controlled somehow, but I need to include the following code when stopping the OSGi bundles to correctly stop all the threads:
{code}
FileSystem.closeAll();
CleanupQueue.getInstance().stop();
DefaultMetricsSystem.INSTANCE.shutdown();
{code}
> Improve resource cleaning when shutting down
> --------------------------------------------
>
> Key: HADOOP-8571
> URL: https://issues.apache.org/jira/browse/HADOOP-8571
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 1.0.0, 2.0.0-alpha, 3.0.0
> Reporter: Guillaume Nodet
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8571) Improve resource cleaning when
shutting down
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated HADOOP-8571:
----------------------------
Target Version/s: 1.1.0
Affects Version/s: 3.0.0
1.0.0
2.0.0-alpha
Your patch seems to be for just the branch-1 code. Any chance we can get a trunk patch as well, with some more detail on what you've changed and why? (Some changes are obvious, but others can do with some more info, would help acceptability).
Thanks!
P.s. Also upload your patch here and grant ASF permissions to use it, otherwise reviewers may be hesitant in reviewing cause we can't integrate it unless you manually give ASF permission to do so.
> Improve resource cleaning when shutting down
> --------------------------------------------
>
> Key: HADOOP-8571
> URL: https://issues.apache.org/jira/browse/HADOOP-8571
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 1.0.0, 2.0.0-alpha, 3.0.0
> Reporter: Guillaume Nodet
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira