[GitHub] xiaohanyu opened a new issue #4274: Should we add `yarn.lock` file?

[GitBox <gi...@apache.org>]

xiaohanyu opened a new issue #4274: Should we add `yarn.lock` file?
URL: https://github.com/apache/incubator-superset/issues/4274
 
 
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [ ] I have checked the superset logs for python stacktraces and included it here as text if any
   - [ ] I have reproduced the issue with at least the latest released version of superset
   - [ ] I have checked the issue tracker for the same issue and I haven't found one similar
   
   
   ### Superset version
   
   master version
   
   ### Expected results
   
   Should add a `yarn.lock` file to main repo to make build reproducible
   
   ### Actual results
   
   No `yarn.lock` or `packge-lock.json` right now.
   
   ### Steps to reproduce
   
   When I try to build my own superset, some times the build may be occationally failed. Then I found that there's no `yarn.lock` file in main repo, so different build may get different version of the same js packages.
   
   Should we add the `yarn.lock` to main repo and do a monthly upgrade to this `yarn.lock` file?
   
   Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services