You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by mmiklavc <gi...@git.apache.org> on 2018/10/04 20:39:48 UTC
[GitHub] metron pull request #1224: METRON-1806: Upgrade Maven Shade Plugin version
GitHub user mmiklavc opened a pull request:
https://github.com/apache/metron/pull/1224
METRON-1806: Upgrade Maven Shade Plugin version
## Contributor Comments
https://issues.apache.org/jira/browse/METRON-1806
Update the maven shade plugin version. There is a bug in the current version that causes issues when shading and relocating various libraries. One such example is log4j. A recent doc update for generating the Elasticsearch X-Pack client jar addressed this issue similarly - https://github.com/apache/metron/pull/1196
**Testing**
Run up full dev and verify data flows through indexing as normal. The management and alerts UI's should function as normal.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [X] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [X] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [X] Have you included steps or a guide to how the change may be verified and tested manually?
- [X] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh
```
- N/A Have you written or updated unit tests and or integration tests to verify your changes?
- N/A If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- N/A Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mmiklavc/metron upgrade-shade-plugin
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1224.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1224
----
commit a60c13ad202e783151d6b2313254daa44755ef01
Author: Michael Miklavcic <mi...@...>
Date: 2018-10-01T22:42:55Z
Upgrade maven-shade-plugin version
----
---
[GitHub] metron pull request #1224: METRON-1806: Upgrade Maven Shade Plugin version
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/1224
---
[GitHub] metron issue #1224: METRON-1806: Upgrade Maven Shade Plugin version
Posted by mmiklavc <gi...@git.apache.org>.
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/1224
Kick travis
---
[GitHub] metron issue #1224: METRON-1806: Upgrade Maven Shade Plugin version
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1224
+1 by inspection. Thanks
---
[GitHub] metron pull request #1224: METRON-1806: Upgrade Maven Shade Plugin version
Posted by mmiklavc <gi...@git.apache.org>.
GitHub user mmiklavc reopened a pull request:
https://github.com/apache/metron/pull/1224
METRON-1806: Upgrade Maven Shade Plugin version
## Contributor Comments
https://issues.apache.org/jira/browse/METRON-1806
Update the maven shade plugin version. There is a bug in the current version that causes issues when shading and relocating various libraries. One such example is log4j. A recent doc update for generating the Elasticsearch X-Pack client jar addressed this issue similarly - https://github.com/apache/metron/pull/1196
**Testing**
Run up full dev and verify data flows through indexing as normal. The management and alerts UI's should function as normal.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [X] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [X] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [X] Have you included steps or a guide to how the change may be verified and tested manually?
- [X] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh
```
- N/A Have you written or updated unit tests and or integration tests to verify your changes?
- N/A If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- N/A Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mmiklavc/metron upgrade-shade-plugin
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1224.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1224
----
commit a60c13ad202e783151d6b2313254daa44755ef01
Author: Michael Miklavcic <mi...@...>
Date: 2018-10-01T22:42:55Z
Upgrade maven-shade-plugin version
commit 7f78a335e580da9a8e6fbaa56e6daaa266f2e3cf
Author: Michael Miklavcic <mi...@...>
Date: 2018-10-08T18:17:46Z
Remove pyc file
----
---
[GitHub] metron pull request #1224: METRON-1806: Upgrade Maven Shade Plugin version
Posted by mmiklavc <gi...@git.apache.org>.
Github user mmiklavc closed the pull request at:
https://github.com/apache/metron/pull/1224
---