You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/09/28 10:22:09 UTC

[GitHub] [skywalking] kezhenxu94 opened a new pull request #3541: Upgrade guava version to support higher JDK version

kezhenxu94 opened a new pull request #3541: Upgrade guava version to support higher JDK version
URL: https://github.com/apache/skywalking/pull/3541
 
 
   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [x] Bug fix
   - [ ] New feature provided
   - [ ] Improve performance
   
   - Related issues
   
   #3540 and #3477 
   
   https://github.com/apache/skywalking/blob/5b039e9747fac98444b4ec423a5d57524202f286/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/annotation/AnnotationScan.java#L54-L56
   
   the `classpath.getTopLevelClassesRecursive("org.apache.skywalking")` returns empty `set` under JDK 8+, and it turns out to be an issue of Guava, see https://github.com/google/guava/issues/3249#issuecomment-416234877 , this patch upgrades the Guava version to 23.1, and I've verified locally the exception disappear and OAP starts successfully

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services