[GitHub] [couchdb] big-r81 commented on a diff in pull request #4380: chore(configure): be more defensive about SpiderMonkey location

["big-r81 (via GitHub)" <gi...@apache.org>]

big-r81 commented on code in PR #4380:
URL: https://github.com/apache/couchdb/pull/4380#discussion_r1083112837


##########
configure.ps1:
##########
@@ -103,6 +103,22 @@ If ($Test) {
     exit 0
 }
 
+# Use the MSVC linker to determine if the respective SpiderMonkey library
+# is available on the linker path.  This heuristic is taken from
+# src/couch/rebar.config.script, please keep them in sync.
+If ($SpiderMonkeyVersion -eq "1.8.5") {
+    $SpiderMonkeyLib = "mozjs185-1.0.lib"
+}
+else {
+    $SpiderMonkeyLib = "mozjs-$SpiderMonkeyVersion.lib"
+}
+
+&link $SpiderMonkeyLib /SUBSYSTEM:CONSOLE /NOENTRY /DLL /OUT:NUL *> $null

Review Comment:
   Is link.exe always available or only if you invoke the VS dev cmd/powershell before?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org