You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by patricker <gi...@git.apache.org> on 2016/09/13 03:57:00 UTC
[GitHub] nifi pull request #1009: NIFI-2764 - MS SQL TINYINT Avro Issue
GitHub user patricker opened a pull request:
https://github.com/apache/nifi/pull/1009
NIFI-2764 - MS SQL TINYINT Avro Issue
Small fix for TINYINT Columns causing Avro serialization to die.
I did not commit the unit test, I did write one and attached it as a comment to the JIRA ticket; it felt pretty dirty how it was written, wasn't sure if I should include it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/patricker/nifi NIFI-2764
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1009.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1009
----
commit 3755ecb96acca90344d25e2717e58ce9940f69b2
Author: patricker <pa...@gmail.com>
Date: 2016-09-13T03:52:58Z
NIFI-2764
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1009: NIFI-2764 - MS SQL TINYINT Avro Issue
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1009
+1 LGTM, thank you for the contribution! Merging to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1009: NIFI-2764 - MS SQL TINYINT Avro Issue
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1009
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1009: NIFI-2764 - MS SQL TINYINT Avro Issue
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1009
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1009: NIFI-2764 - MS SQL TINYINT Avro Issue
Posted by patricker <gi...@git.apache.org>.
Github user patricker commented on the issue:
https://github.com/apache/nifi/pull/1009
Updated to include mocked unit test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---