You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/18 07:21:40 UTC

[GitHub] [arrow-ballista] r4ntix opened a new pull request, #384: Add DistinctCount support

r4ntix opened a new pull request, #384:
URL: https://github.com/apache/arrow-ballista/pull/384

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #5
   
    # Rationale for this change
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   See #5 
   
   # What changes are included in this PR?
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   * Add `distinct` field for `PhysicalAggregateExprNode` in `ballista.proto` file
   * Add `DistinctCount` support in `to_proto.rs` file
   
   # Are there any user-facing changes?
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   
   None


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-ballista] Dandandan merged pull request #384: Add DistinctCount support

Posted by GitBox <gi...@apache.org>.
Dandandan merged PR #384:
URL: https://github.com/apache/arrow-ballista/pull/384


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-ballista] r4ntix commented on pull request #384: Add DistinctCount support

Posted by GitBox <gi...@apache.org>.
r4ntix commented on PR #384:
URL: https://github.com/apache/arrow-ballista/pull/384#issuecomment-1283369985

   @andygrove I add a roundtrip_distinct_count test. Could you please review?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-ballista] r4ntix commented on pull request #384: Add DistinctCount support

Posted by GitBox <gi...@apache.org>.
r4ntix commented on PR #384:
URL: https://github.com/apache/arrow-ballista/pull/384#issuecomment-1282485157

   > Thanks @r4ntix. This looks good, but could you add a roundtrip test in `mod roundtrip_tests`?
   
   Thanks feedback, I will add test for this :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-ballista] andygrove commented on pull request #384: Add DistinctCount support

Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #384:
URL: https://github.com/apache/arrow-ballista/pull/384#issuecomment-1282390795

   Thanks @r4ntix. This looks good, but could you add a roundtrip test in `mod roundtrip_tests`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-ballista] Dandandan commented on pull request #384: Add DistinctCount support

Posted by GitBox <gi...@apache.org>.
Dandandan commented on PR #384:
URL: https://github.com/apache/arrow-ballista/pull/384#issuecomment-1283494646

   Thank you @r4ntix 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org