[GitHub] [arrow] kou commented on a diff in pull request #34048: GH-32292: [R][Packaging] Use binaries built on CentOS 7 for Ubuntu < 22.04

["kou (via GitHub)" <gi...@apache.org>]

kou commented on code in PR #34048:
URL: https://github.com/apache/arrow/pull/34048#discussion_r1143399017


##########
r/tools/nixlibs.R:
##########
@@ -99,8 +99,8 @@ download_binary <- function(lib) {
 # * Some other string: a "distro-version" that corresponds to a binary that is
 #   available, to override what this function may discover by default.
 #   Possible values are:
-#    * "centos-7" (gcc 8 (devtoolset), openssl 1, glib 2.17)
-#    * "ubuntu-18.04" (gcc 8, openssl 1, glib 2.27)
+#    * "centos-7" (gcc 8 (devtoolset), _GLIBCXX_USE_CXX11_ABI=0, openssl 1.0)

Review Comment:
   I kept the `centos-7` name for backward compatibility. (I thought that some users may specify `centos-7` explicitly.)
   
   I'll rename them as the followings:
   
   * `centos-7` -> `openssl-1.0`
   * `centos-7-openssl-1.1` -> `openssl-1.1`
   * `ubuntu-22.04` -> `openssl-3.0`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org