You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/10 18:02:09 UTC

[GitHub] [airflow] tanelk commented on a diff in pull request #24366: Send DAG timeout callbacks to processor outside of prohibit_commit

tanelk commented on code in PR #24366:
URL: https://github.com/apache/airflow/pull/24366#discussion_r894779661


##########
airflow/jobs/scheduler_job.py:
##########
@@ -1159,10 +1159,7 @@ def _schedule_dag_run(
                 msg='timed_out',
             )
 
-            # Send SLA & DAG Success/Failure Callbacks to be executed
-            self._send_dag_callbacks_to_processor(dag, callback_to_execute)

Review Comment:
   No, the callback is executed once, because the `callback` it returned was `None`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org