You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2015/09/01 16:44:05 UTC
Review Request 38007: Need a robust check for the existence of a
package
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38007/
-----------------------------------------------------------
Review request for Ambari and Dmitro Lisnichenko.
Bugs: AMBARI-12961
https://issues.apache.org/jira/browse/AMBARI-12961
Repository: ambari
Description
-------
There is a problem in the way Ambari checks for existence of packages to skip
calls to install.
The string used to install usually has some wild-cards e.g. `zookeeper_2_2_*`.
If install is called using this string, it will pull in all packages that
satisfy the condition.
* zookeeper_2_2_6_0_2800-server-3.4.6.2.2.6.0-2800
* zookeeper_2_2_6_0_2800-3.4.6.2.2.6.0-2800
However, if "hadoop_2_2*" is installed first then it only pulls in
zookeeper_2_2_6_0_2800-3.4.6.2.2.6.0-2800. Existence of this package satisfies
the check if `zookeeper_2_2_*` is installed and thus
`zookeeper_2_2_6_0_2800-server-3.4.6.2.2.6.0-2800` does not get installed.
This resulted in <https://issues.apache.org/jira/browse/AMBARI-12874> where
"hdp-select set zookeeper-server VERSION" is not called as
zookeeper_2_2_6_0_2800-server-3.4.6.2.2.6.0-2800 never got installed.
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.2/services/ZOOKEEPER/metainfo.xml 2f92549
ambari-server/src/main/resources/stacks/HDP/2.3/services/ZOOKEEPER/metainfo.xml fdce582
ambari-server/src/main/resources/stacks/HDP/2.4/services/ZOOKEEPER/metainfo.xml 63e7574
Diff: https://reviews.apache.org/r/38007/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 38007: Need a robust check for the existence of a
package
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38007/#review97287
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Sept. 1, 2015, 2:44 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38007/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2015, 2:44 p.m.)
>
>
> Review request for Ambari and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-12961
> https://issues.apache.org/jira/browse/AMBARI-12961
>
>
> Repository: ambari
>
>
> Description
> -------
>
> There is a problem in the way Ambari checks for existence of packages to skip
> calls to install.
>
> The string used to install usually has some wild-cards e.g. `zookeeper_2_2_*`.
> If install is called using this string, it will pull in all packages that
> satisfy the condition.
>
> * zookeeper_2_2_6_0_2800-server-3.4.6.2.2.6.0-2800
> * zookeeper_2_2_6_0_2800-3.4.6.2.2.6.0-2800
>
> However, if "hadoop_2_2*" is installed first then it only pulls in
> zookeeper_2_2_6_0_2800-3.4.6.2.2.6.0-2800. Existence of this package satisfies
> the check if `zookeeper_2_2_*` is installed and thus
> `zookeeper_2_2_6_0_2800-server-3.4.6.2.2.6.0-2800` does not get installed.
>
> This resulted in <https://issues.apache.org/jira/browse/AMBARI-12874> where
> "hdp-select set zookeeper-server VERSION" is not called as
> zookeeper_2_2_6_0_2800-server-3.4.6.2.2.6.0-2800 never got installed.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/ZOOKEEPER/metainfo.xml 2f92549
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ZOOKEEPER/metainfo.xml fdce582
> ambari-server/src/main/resources/stacks/HDP/2.4/services/ZOOKEEPER/metainfo.xml 63e7574
>
> Diff: https://reviews.apache.org/r/38007/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>