You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by qu...@apache.org on 2013/04/21 02:27:38 UTC

git commit: [flex-sdk] - Fixes FLEX-18697. Check-in tests run, mustella passes.

Updated Branches:
  refs/heads/develop 81b3ddaea -> 8bf8aa7b2


Fixes FLEX-18697.  Check-in tests run, mustella passes.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/8bf8aa7b
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/8bf8aa7b
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/8bf8aa7b

Branch: refs/heads/develop
Commit: 8bf8aa7b28d346d43d8f4e78bf731b74ee9c1753
Parents: 81b3dda
Author: quetwo <ni...@theflexgroup.org>
Authored: Sat Apr 20 20:27:08 2013 -0400
Committer: quetwo <ni...@theflexgroup.org>
Committed: Sat Apr 20 20:27:08 2013 -0400

----------------------------------------------------------------------
 .../projects/framework/src/mx/utils/ObjectUtil.as  |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/8bf8aa7b/frameworks/projects/framework/src/mx/utils/ObjectUtil.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/framework/src/mx/utils/ObjectUtil.as b/frameworks/projects/framework/src/mx/utils/ObjectUtil.as
index ae897e9..52a04ea 100644
--- a/frameworks/projects/framework/src/mx/utils/ObjectUtil.as
+++ b/frameworks/projects/framework/src/mx/utils/ObjectUtil.as
@@ -1312,7 +1312,7 @@ public class ObjectUtil
                 key += flag;
                 var value:String = options[flag] as String;
                 if (value != null)
-                    key += value;
+					key += options[flag].toString();
             }
         }
         return key;


Re: git commit: [flex-sdk] - Fixes FLEX-18697. Check-in tests run, mustella passes.

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

Why not this?

                var value:String = options[flag].toString();
                if (value != null)
                    key += value;

The issue occurs when options[flag] is not a String but a Boolean right? So I think what you checked in in would still cause it to not be added to the key? (Off top of head not tested.)

Thanks,
Justin