You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/08/22 08:44:58 UTC

[GitHub] [shardingsphere] tuichenchuxin opened a new issue, #20393: support parse ALTER PROCEDURE

tuichenchuxin opened a new issue, #20393:
URL: https://github.com/apache/shardingsphere/issues/20393

   Hi community,
   
   This issue is for #20305.
   ref to #6480
   
   ## Background
   ShardingSphere parser engine helps users parse a SQL to get the AST (Abstract Syntax Tree) and visit this tree to get SQLStatement (Java Object). At present, this parser engine can handle SQLs for `MySQL`, `PostgreSQL`, `SQLServer`, `openGauss` and `Oracle`, which means we have to understand different database dialect SQLs.
   More details: 
   https://shardingsphere.apache.org/document/current/en/reference/sharding/parse/
   
   ## Task
   This issue is to support more sql parse. 
   
   - [ ] ALTER PROCEDURE [doc](https://docs.oracle.com/en/database/oracle/oracle-database/19/sqlrf/ALTER-PROCEDURE.html#GUID-24A5796F-7D97-49D4-8448-7E541CB73AC6)
   
   ## Process
   1. Compare SQL definitions in [Oficial SQL Doc](https://docs.oracle.com/en/database/oracle/oracle-database/18/lnpls/plsql-language-elements.html#GUID-285DFAEE-1A34-4248-BA4B-2591476A0C3C) and [ShardingSphere SQL Doc](https://github.com/apache/shardingsphere/tree/master/shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle).
   2. If there is any difference in ShardingSphere SQL Doc, please correct them by referring to the Official SQL Doc.
   3. Run `mvn install the current_file_module`.
   4. Check whether there are any exceptions. If indeed, please fix them. (`Especially xxxVisitor.class`).
   5. Add new corresponding SQL case in SQL Cases and expected parsed result in Expected Statment XML.
   6. Run SQLParserParameterizedTest to make sure no exceptions.
   
   ## Relevant Skills
   1. Master JAVA language
   2. Have a basic understanding of Antlr g4 file
   3. Be familiar with Oracle SQLs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu commented on issue #20393: support parse ALTER PROCEDURE

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #20393:
URL: https://github.com/apache/shardingsphere/issues/20393#issuecomment-1225043769

   Fixed by https://github.com/apache/shardingsphere/pull/20463.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu closed issue #20393: support parse ALTER PROCEDURE

Posted by GitBox <gi...@apache.org>.
strongduanmu closed issue #20393: support parse ALTER PROCEDURE
URL: https://github.com/apache/shardingsphere/issues/20393


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tianhao960 commented on issue #20393: support parse ALTER PROCEDURE

Posted by GitBox <gi...@apache.org>.
tianhao960 commented on issue #20393:
URL: https://github.com/apache/shardingsphere/issues/20393#issuecomment-1223830777

   hi, @tuichenchuxin , I've just post a pr of alter procedure. 
   ref: https://github.com/apache/shardingsphere/pull/20463


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org