You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/30 06:55:15 UTC

[GitHub] [shardingsphere] jiangML commented on a diff in pull request #22505: Refactor agent plugin to support JDBC

jiangML commented on code in PR #22505:
URL: https://github.com/apache/shardingsphere/pull/22505#discussion_r1035588502


##########
agent/plugins/metrics/prometheus/src/main/java/org/apache/shardingsphere/agent/metrics/prometheus/collector/BuildInfoCollector.java:
##########
@@ -32,23 +33,28 @@
  * Build information collector.
  */
 @Slf4j
+@AllArgsConstructor
 public final class BuildInfoCollector extends Collector {
     
     private static final String PROXY_BOOTSTRAP_CLASS = "org.apache.shardingsphere.proxy.Bootstrap";
     
     private static final PrometheusWrapperFactory FACTORY = new PrometheusWrapperFactory();
     
+    private final boolean isRunWithProxy;

Review Comment:
   I mean the same thing, let me adjust it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org